Skip to content

8339399: ZGC: Remove unnecessary page reset when splitting pages #20824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsikstro wants to merge 1 commit into from
Closed

8339399: ZGC: Remove unnecessary page reset when splitting pages #20824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/hotspot/share/gc/z/zPage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,6 @@ void ZPage::verify_remset_after_reset(ZPageAge prev_age, ZPageResetType type) {

// Old-to-old reset
switch (type) {
case ZPageResetType::Splitting:
// Page is on the way to be destroyed or reused, delay
// clearing until the page is reset for Allocation.
break;

case ZPageResetType::InPlaceRelocation:
// Relocation failed and page is being compacted in-place.
// The remset bits are flipped each young mark start, so
Expand Down Expand Up @@ -188,11 +183,9 @@ ZPage* ZPage::split(size_t split_of_size) {
ZPage* ZPage::split_with_pmem(ZPageType type, const ZPhysicalMemory& pmem) {
// Resize this page
const ZVirtualMemory vmem = _virtual.split(pmem.size());
assert(vmem.end() == _virtual.start(), "Should be consecutive");

reset_type_and_size(type_from_size(_virtual.size()));
reset(_age, ZPageResetType::Splitting);

assert(vmem.end() == _virtual.start(), "Should be consecutive");

log_trace(gc, page)("Split page [" PTR_FORMAT ", " PTR_FORMAT ", " PTR_FORMAT "]",
untype(vmem.start()),
Expand Down
2 changes: 0 additions & 2 deletions src/hotspot/share/gc/z/zPage.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ enum class ZPageResetType {
// Page was not selected for relocation, all objects
// stayed, but the page aged.
FlipAging,
// The page was split and needs to be reset
Splitting,
};

class ZPage : public CHeapObj<mtGC> {
Expand Down