8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect

[lmesnik]

est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of strcmp results here:

for (i=0; i<METH_NUM; i++)
if (strcmp(methNam,METHODS[i][0]) &&
strcmp(methSig,METHODS[i][1])) {
printf("CHECK PASSED: method name: "%s"\tsignature: "%s" %d\n",
methNam, methSig, i);
if (checkStatus == PASSED)
bpEvents[i]++;
break;
}

So test passed when both strcmp (name,sig) are not zero.

The test passes only because there are 2 methods that are checked and it increases counters for "incorrect" methods.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect

Reviewers

• Igor Ignatyev (@iignatev - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2084/head:pull/2084
$ git checkout pull/2084

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c7b78f8)
• 00: Full (009db2e)

[iignatev]

@lmesnik , looks good to me, besides a few nits.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect

Reviewed-by: iignatyev, sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• d18d26e: 8259350: Add some internal debugging APIs to the debug agent
• a6b2162: 8259278: Optimize Vector API slice and unslice operations
• da6bcf9: 8255019: Shenandoah: Split STW and concurrent mark into separate classes
• aba3431: 8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result
• 8554fe6: 8253866: Security Libs Terminology Refresh
• c2a3c7e: 8259727: Remove redundant "target" arguments to methods in Links
• 1620664: 8259723: Move Table class to formats.html package
• 38a1201: 8258912: Remove JVM options CountJNICalls and CountJVMCalls
• be57cf1: 8226416: MonitorUsedDeflationThreshold can cause repeated async deflation requests
• c822eda: 8259699: Reduce char[] copying in URLEncoder.encode(String, Charset)
• ... and 30 more: https://git.openjdk.java.net/jdk/compare/916ab4e7d8aeac010d9ff267a67a9da34017eac3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Hi Leonid,
LGTM++
Thanks,
Serguei

[lmesnik]

/integrate

[openjdk]

@lmesnik Since your change was applied there have been 62 commits pushed to the master branch:

• fe84ecd: 8259048: (tz) Upgrade time-zone data to tzdata2020f
• 9aa5672: 8259068: Streamline class loader locking
• 27a39c8: 8193031: Collections.addAll is likely to perform worse than Collection.addAll
• 5855d52: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
• 360c722: 8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
• b78cd63: 8259846: [BACKOUT] JDK-8259278 Optimize Vector API slice and unslice operations
• eb7fa00: 8259216: javadoc omits method receiver for any nested type annotation
• bcf20a0: 8259777: Incorrect predication condition generated by ADLC
• bbac91a: 8257959: Add gtest run with -XX:+UseLargePages
• 707bce0: 8257212: (bf spec) Clarify byte order of the buffer returned by CharBuffer.subsequence(int,int)
• ... and 52 more: https://git.openjdk.java.net/jdk/compare/916ab4e7d8aeac010d9ff267a67a9da34017eac3...master

Your commit was automatically rebased without conflicts.

Pushed as commit d7d34dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.