8339524: Clean up a few ExtendedRobot tests by alisenchung · Pull Request #20846 · openjdk/jdk

alisenchung · 2024-09-04T03:34:34Z

Cleaning up tests building ExtendedRobot that shouldn't be.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8339524: Clean up a few ExtendedRobot tests (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer)
Alexey Ivanov (@aivanov-jdk - Reviewer) Review applies to bfa743b0
Phil Race (@prrace - Reviewer) Review applies to ca7b7532

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20846/head:pull/20846
$ git checkout pull/20846

Update a local copy of the PR:
$ git checkout pull/20846
$ git pull https://git.openjdk.org/jdk.git pull/20846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20846

View PR using the GUI difftool:
$ git pr show -t 20846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20846.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-09-04T03:35:19Z

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-09-04T03:36:29Z

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339524: Clean up a few ExtendedRobot tests

Reviewed-by: honkar, aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2232 new commits pushed to the master branch:

4d898aa: 8344896: Remove obsolete checks for AWTPermission accessClipboard
08dfc4a: 8344213: Cleanup OpaqueLoop*Node verification code for Assertion Predicates
593a589: 8344319: SM cleanup in jdk.dynalink module
15ae8d0: 8319993: Update Unicode Data Files to 16.0.0
a032de2: 8344577: Virtual thread tests are timing out on some macOS systems
4110d39: 8344865: SM cleanup in sun/reflect/annotation
1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
c6b14c6: 8344841: ClassPrinter prints confusing value for null
... and 2222 more: https://git.openjdk.org/jdk/compare/6238bc8da2abe7a1f0cdd98c0af01e9ba1869ec3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-09-04T03:36:51Z

@alisenchung The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

test/jdk/java/awt/Robot/ModifierRobotKey/ModifierRobotEnhancedKeyTest.java

mlbridge · 2024-09-05T15:14:20Z

Webrevs

honkar-jdk

Are these the only two tests being changed as part of this PR?
Please update copyright years and expand import statements.

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java

aivanov-jdk · 2024-09-20T10:02:53Z

Cleaning up tests building ExtendedRobot that shouldn't be.

The title suggest a larger amount of clean-up. “Clean up a few tests” could be better. (Git recommends the use of imperative mood in titles: “Clean up” instead of “Cleaning up”, and it's shorter.

bridgekeeper · 2024-10-18T13:08:14Z

@alisenchung This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

alisenchung · 2024-10-22T20:25:43Z

@aivanov-jdk @honkar-jdk I've verified that these 2 tests are the only ones currently building ExtendedRobot unnecessarily. I will migrate some ExtendedRobot methods to Robot after this but I would like to clean these tests up first to make it simpler. Can you take another look at these 2 tests?

test/jdk/java/awt/TrayIcon/ActionEventTest/ActionEventTest.java

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java

test/jdk/java/awt/TrayIcon/ActionEventTest/ActionEventTest.java

aivanov-jdk · 2024-10-24T14:37:19Z

I will migrate some ExtendedRobot methods to Robot

Are you saying you'll add new public methods to java.awt.Robot?

alisenchung · 2024-11-14T19:15:05Z

I will migrate some ExtendedRobot methods to Robot

Are you saying you'll add new public methods to java.awt.Robot?

Yes, I will be adding new public methods to Robot in this PR #20846
@aivanov-jdk Can you take another look at these tests?

aivanov-jdk · 2024-11-14T19:23:36Z

I will migrate some ExtendedRobot methods to Robot

Are you saying you'll add new public methods to java.awt.Robot?

Yes, I will be adding new public methods to Robot in this PR #20846

You referenced this same PR.

Is it really the intention? What kind of methods are you planning to add to the Robot class?

Robot is a public API, adding new public methods to it requires a CSR.

@aivanov-jdk Can you take another look at these tests?

I will. If I understand correctly, you updated the PR less than 10 minutes ago.

test/jdk/java/awt/TrayIcon/ActionEventTest/ActionEventTest.java

honkar-jdk · 2024-11-14T21:17:22Z

@aivanov-jdk

Is it really the intention? What kind of methods are you planning to add to the Robot class?

Robot is a public API, adding new public methods to it requires a CSR.

This seems to be the correct PR: #22044

honkar-jdk

LGTM apart from the following minor inline comments.

Since @aivanov-jdk reviewed previously please wait to see in case he wants to add anything additional.

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java

honkar-jdk

Updated changes LGTM

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java

alisenchung · 2024-11-19T21:31:35Z

imports were fixed, test is passing on windows now

aivanov-jdk

Looks good to me except for adding robot.delay(500).

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java

alisenchung · 2024-11-25T17:59:52Z

All comments resolved, can I get a re-approval for the new changes

openjdk · 2024-11-25T18:00:46Z

⚠️ @alisenchung This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

honkar-jdk

Updated changes LGTM.

alisenchung · 2024-11-25T22:31:44Z

/integrate

openjdk · 2024-11-25T22:33:00Z

Going to push as commit 1623257.
Since your change was applied there have been 2235 commits pushed to the master branch:

0276079: 8344667: Remove most uses of AWT Permissions from the desktop module
8de158a: 8339134: Callers of Exceptions::fthrow should ensure exception message lengths avoid the INT_MAX limits of os::vsnprintf
df2d4c1: 8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources
4d898aa: 8344896: Remove obsolete checks for AWTPermission accessClipboard
08dfc4a: 8344213: Cleanup OpaqueLoop*Node verification code for Assertion Predicates
593a589: 8344319: SM cleanup in jdk.dynalink module
15ae8d0: 8319993: Update Unicode Data Files to 16.0.0
a032de2: 8344577: Virtual thread tests are timing out on some macOS systems
4110d39: 8344865: SM cleanup in sun/reflect/annotation
1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
... and 2225 more: https://git.openjdk.org/jdk/compare/6238bc8da2abe7a1f0cdd98c0af01e9ba1869ec3...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-11-25T22:33:07Z

@alisenchung Pushed as commit 1623257.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

init commit

c153379

openjdk bot added the client client-libs-dev@openjdk.org label Sep 4, 2024

TejeshR13 reviewed Sep 4, 2024

View reviewed changes

test/jdk/java/awt/Robot/ModifierRobotKey/ModifierRobotEnhancedKeyTest.java Show resolved Hide resolved

alisenchung added 2 commits September 5, 2024 08:04

reverted some tests actually using ExtendedRobot

32c6db4

revert test using ExtendedRobot

5591939

alisenchung marked this pull request as ready for review September 5, 2024 15:09

openjdk bot added the rfr Pull request is ready for review label Sep 5, 2024

honkar-jdk reviewed Sep 7, 2024

View reviewed changes

aivanov-jdk suggested changes Sep 20, 2024

View reviewed changes

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java Outdated Show resolved Hide resolved

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java Outdated Show resolved Hide resolved

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java Show resolved Hide resolved

alisenchung changed the title ~~8339524: Clean up ExtendedRobot tests~~ 8339524: Clean up a few ExtendedRobot tests Oct 18, 2024

update tests

ca7b753

prrace approved these changes Oct 22, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2024

aivanov-jdk suggested changes Oct 24, 2024

View reviewed changes

update tests

04eec25

openjdk bot removed the ready Pull request is ready to be integrated label Nov 14, 2024

honkar-jdk suggested changes Nov 14, 2024

View reviewed changes

test/jdk/java/awt/TrayIcon/ActionEventTest/ActionEventTest.java Outdated Show resolved Hide resolved

test/jdk/java/awt/TrayIcon/ActionEventTest/ActionEventTest.java Show resolved Hide resolved

alisenchung added 2 commits November 15, 2024 06:19

readd ER

50b582c

revert ActionEventTest

13f3112

alisenchung added 2 commits November 15, 2024 06:31

revert ActionEventTest

be05509

EOF newline ActionEventTest

6a980a4

honkar-jdk approved these changes Nov 15, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2024

robot init in main, static volatile passed

6b0b6b0

openjdk bot removed the ready Pull request is ready to be integrated label Nov 18, 2024

import to avoid full qualified names

2750ad7

honkar-jdk approved these changes Nov 18, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2024

aivanov-jdk suggested changes Nov 18, 2024

View reviewed changes

fix imports

bfa743b

openjdk bot removed the ready Pull request is ready to be integrated label Nov 19, 2024

aivanov-jdk approved these changes Nov 22, 2024

View reviewed changes

test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java Outdated Show resolved Hide resolved

openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2024

alisenchung added 2 commits November 25, 2024 09:57

remove robot delay

ed098ab

Merge branch '8339524' of github.com:alisenchung/jdk into 8339524

4436a65

openjdk bot removed the ready Pull request is ready to be integrated label Nov 25, 2024

add frame title

4f8c8d9

honkar-jdk approved these changes Nov 25, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 25, 2024

openjdk bot added the integrated Pull request has been integrated label Nov 25, 2024

openjdk bot closed this Nov 25, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 25, 2024

Conversation

alisenchung commented Sep 4, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 4, 2024

Uh oh!

openjdk bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 4, 2024

Uh oh!

Uh oh!

mlbridge bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

honkar-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aivanov-jdk commented Sep 20, 2024

Uh oh!

bridgekeeper bot commented Oct 18, 2024

Uh oh!

alisenchung commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aivanov-jdk commented Oct 24, 2024

Uh oh!

alisenchung commented Nov 14, 2024

Uh oh!

aivanov-jdk commented Nov 14, 2024

Uh oh!

Uh oh!

Uh oh!

honkar-jdk commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

honkar-jdk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

honkar-jdk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alisenchung commented Nov 19, 2024

Uh oh!

aivanov-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alisenchung commented Nov 25, 2024

Uh oh!

openjdk bot commented Nov 25, 2024

Uh oh!

honkar-jdk left a comment

alisenchung commented Sep 4, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Sep 4, 2024 •

edited

Loading

mlbridge bot commented Sep 5, 2024 •

edited

Loading

honkar-jdk commented Nov 14, 2024 •

edited

Loading

honkar-jdk left a comment •

edited

Loading

honkar-jdk left a comment •

edited

Loading