8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #20847

offamitkumar · 2024-09-04T07:04:36Z

The error mentioned in the JBS issue is seen on x86_64 as well as on s390x during the build, with --enable-ubsan configuration.

I have added -1 to enum to fix this issue for now as mentioned by @MBaesken. But removing the assert itself is also a possible solution, mentioned on the JBS issue.

So I will happy to follow the reviews/suggestion if this is not a good fix.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Warning

⚠️ Found leading lowercase letter in issue title for 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'

Issue

JDK-8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' (Bug - P4)

Reviewers

Stefan Karlsson (@stefank - Reviewer)
Vladimir Kozlov (@vnkozlov - Reviewer)
Dean Long (@dean-long - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20847/head:pull/20847
$ git checkout pull/20847

Update a local copy of the PR:
$ git checkout pull/20847
$ git pull https://git.openjdk.org/jdk.git pull/20847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20847

View PR using the GUI difftool:
$ git pr show -t 20847

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20847.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-09-04T07:05:29Z

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-09-04T07:06:40Z

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'

Reviewed-by: stefank, kvn, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

96df5a6: 8339316: Test runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java fails after JDK-8338257
55312e1: 8338937: Optimize the string concatenation of ClassDesc
d4dfa01: 8338530: CDS warning Skipping java/lang/invoke/BoundMethodHandle$Species_LLLL
b8d560b: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize
1353601: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5
433f6d8: 8339492: StackMapDecoder::writeFrames makes lots of allocations
ef96a7b: 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS
12d060a: 8339148: Make os::Linux::active_processor_count() public
0cfd08f: 8339112: Move JVM Klass flags out of AccessFlags
6f8714e: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long
... and 7 more: https://git.openjdk.org/jdk/compare/9a1024dec68057c7c581ac0a38fc7f96489a0a76...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-09-04T07:07:13Z

@offamitkumar The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-09-04T07:10:37Z

Webrevs

01: Full - Incremental (c9dea975)
00: Full (1a945549)

stefank

Shouldn't this new enum value also be used in the place that sets DepType to -1?:

  _type       = (DepType)(end_marker-1);  // defeat "already at end" assert

(An alternative could be to find another way to defeat the "already at end" assert, but I guess that's out-of-scope for this PR)

offamitkumar · 2024-09-04T09:43:20Z

Shouldn't this new enum value also be used in the place that sets DepType to -1?:

Done, Thanks for the suggestion & Please have a look again.

stefank

Looks good from my POV, but I'd like to see one of the compiler devs to properly Review this.

stefank · 2024-09-04T13:16:07Z

/reviewers 2

openjdk · 2024-09-04T13:17:11Z

@stefank
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

vnkozlov

Good.

dean-long · 2024-09-05T02:59:06Z

src/hotspot/share/code/dependencies.hpp

@@ -103,6 +103,9 @@ class Dependencies: public ResourceObj {
  // type now includes N, that is, all super types of N.
  //
  enum DepType {
+    // _type is initially set to -1, to prevent "already at end" assert
+    undefined_dependency = -1,


Preserving the existing value seems fine, though it appears any value >= TYPE_LIMIT would work just as well.

FWIW, I was also entertaining the idea of a solution like that with the hope that it would fit better with the usage in the iterators.

offamitkumar · 2024-09-05T06:59:57Z

I tested the builds and fastdebug & release builds are fine, so let's integrate. Thanks @stefank @vnkozlov @dean-long for the suggestion & approval :-)

/integrate

openjdk · 2024-09-05T07:01:30Z

Going to push as commit 28de44d.
Since your change was applied there have been 17 commits pushed to the master branch:

96df5a6: 8339316: Test runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java fails after JDK-8338257
55312e1: 8338937: Optimize the string concatenation of ClassDesc
d4dfa01: 8338530: CDS warning Skipping java/lang/invoke/BoundMethodHandle$Species_LLLL
b8d560b: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize
1353601: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5
433f6d8: 8339492: StackMapDecoder::writeFrames makes lots of allocations
ef96a7b: 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS
12d060a: 8339148: Make os::Linux::active_processor_count() public
0cfd08f: 8339112: Move JVM Klass flags out of AccessFlags
6f8714e: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long
... and 7 more: https://git.openjdk.org/jdk/compare/9a1024dec68057c7c581ac0a38fc7f96489a0a76...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-09-05T07:01:38Z

@offamitkumar Pushed as commit 28de44d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

make ubsan happy

1a94554

openjdk bot changed the title ~~8332461~~ 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' Sep 4, 2024

openjdk bot added the rfr Pull request is ready for review label Sep 4, 2024

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 4, 2024

stefank suggested changes Sep 4, 2024

View reviewed changes

initialise with undefined_dependency

c9dea97

stefank approved these changes Sep 4, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 4, 2024

openjdk bot removed the ready Pull request is ready to be integrated label Sep 4, 2024

vnkozlov approved these changes Sep 4, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 4, 2024

dean-long reviewed Sep 5, 2024

View reviewed changes

dean-long approved these changes Sep 5, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Sep 5, 2024

openjdk bot closed this Sep 5, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2024

offamitkumar deleted the ubsan_v0 branch November 24, 2024 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #20847

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #20847

Uh oh!

offamitkumar commented Sep 4, 2024 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Sep 4, 2024

Uh oh!

openjdk bot commented Sep 4, 2024 •

edited

Loading

Uh oh!

openjdk bot commented Sep 4, 2024

Uh oh!

mlbridge bot commented Sep 4, 2024 •

edited

Loading

Uh oh!

stefank left a comment

Uh oh!

offamitkumar commented Sep 4, 2024

Uh oh!

stefank left a comment

Uh oh!

stefank commented Sep 4, 2024

Uh oh!

openjdk bot commented Sep 4, 2024

Uh oh!

vnkozlov left a comment

Uh oh!

dean-long Sep 5, 2024 •

edited

Loading

Uh oh!

stefank Sep 5, 2024

Uh oh!

offamitkumar commented Sep 5, 2024

Uh oh!

openjdk bot commented Sep 5, 2024

Uh oh!

openjdk bot commented Sep 5, 2024

Uh oh!

Uh oh!

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #20847

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #20847

Uh oh!

Conversation

offamitkumar commented Sep 4, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Warning

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Sep 4, 2024

Uh oh!

openjdk bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 4, 2024

Uh oh!

mlbridge bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

stefank left a comment

Choose a reason for hiding this comment

Uh oh!

offamitkumar commented Sep 4, 2024

Uh oh!

stefank left a comment

Choose a reason for hiding this comment

Uh oh!

stefank commented Sep 4, 2024

Uh oh!

openjdk bot commented Sep 4, 2024

Uh oh!

vnkozlov left a comment

Choose a reason for hiding this comment

Uh oh!

dean-long Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stefank Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

offamitkumar commented Sep 5, 2024

Uh oh!

openjdk bot commented Sep 5, 2024

Uh oh!

openjdk bot commented Sep 5, 2024

Uh oh!

Uh oh!

offamitkumar commented Sep 4, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Sep 4, 2024 •

edited

Loading

mlbridge bot commented Sep 4, 2024 •

edited

Loading

dean-long Sep 5, 2024 •

edited

Loading