New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8259726: Use of HashSet leads to undefined order in test output #2086
Conversation
|
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@jonathan-gibbons This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 55 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@jonathan-gibbons Since your change was applied there have been 144 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 982e42b. |
Small cleanup in code, changing
HashSet
toArrayList
, with a corresponding beneficial impact on tests.The irony is that this was originally done with the intent to change the element type from
String
toHtmlId
, but having tried that, it seems better to localize the conversion from ids to class names, so I just cleaned up the expository comment a bit.I rewrapped some of the long text block lines as well.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2086/head:pull/2086
$ git checkout pull/2086