Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8259726: Use of HashSet leads to undefined order in test output #2086

Closed
wants to merge 2 commits into from

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jan 14, 2021

Small cleanup in code, changing HashSet to ArrayList, with a corresponding beneficial impact on tests.

The irony is that this was originally done with the intent to change the element type from String to HtmlId, but having tried that, it seems better to localize the conversion from ids to class names, so I just cleaned up the expository comment a bit.

I rewrapped some of the long text block lines as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259726: Use of HashSet leads to undefined order in test output

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2086/head:pull/2086
$ git checkout pull/2086

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 14, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the javadoc label Jan 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 14, 2021

Webrevs

Loading

hns
hns approved these changes Jan 19, 2021
Copy link
Member

@hns hns left a comment

Looks good!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 19, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259726: Use of HashSet leads to undefined order in test output

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • c0e9c44: 8259962: Shenandoah: task queue statistics is inconsistent after JDK-8255019
  • 82adfb3: 8134540: Much nearly duplicated code for PerfMemory support
  • a9519c8: 8259924: GitHub actions fail on Linux x86_32 with "Could not configure libc6:i386"
  • 139f5d3: 8259035: Comments for load order of hsdis should be updated
  • bd81ccf: 8259957: Build failure without C1 Compiler after JDK-8258004
  • dfee7b8: 8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)"
  • 14ce8f1: 8259870: zBarrier.inline.hpp should not include javaClasses.hpp
  • a1a851b: Merge
  • bb0821e: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
  • cd25bf2: 8259574: SIGSEGV in BFSClosure::closure_impl
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/bf28f9255515feeb929cbdd2b0d2d51501b25e91...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 19, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Jan 25, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@jonathan-gibbons Since your change was applied there have been 144 commits pushed to the master branch:

  • d6fb9d7: 8255464: Cannot access ModuleTree in a CompilationUnitTree
  • 12ccd21: 8260289: Unable to customize module lists after change JDK-8258411
  • 73c78c8: 8260329: Update references to TAOCP to latest edition
  • 5b0b24b: 8260381: ProblemList com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java on Win with ZGC
  • 47c7dc7: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures
  • ef247ab: 8260308: Update LogCompilation junit to 4.13.1
  • d076977: 8260169: LogCompilation: Unexpected method mismatch
  • 6e03735: 8259845: Move placeholder implementation details to cpp file and add logging
  • ca20c63: 8259710: Inlining trace leaks memory
  • 09489e2: 8260338: Some fields in HaltNode is not cloned
  • ... and 134 more: https://git.openjdk.java.net/jdk/compare/bf28f9255515feeb929cbdd2b0d2d51501b25e91...master

Your commit was automatically rebased without conflicts.

Pushed as commit 982e42b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@jonathan-gibbons jonathan-gibbons deleted the tabClasses branch Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants