8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser #20867

kumarabhi006 · 2024-09-05T10:34:40Z

There is no Swatches tab available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test instructions.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser (Bug - P4)

Reviewers

Prasanta Sadhukhan (@prsadhuk - Reviewer) Review applies to 677cb0e9
Tejesh R (@TejeshR13 - Reviewer) Review applies to 56bb68d9
Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20867/head:pull/20867
$ git checkout pull/20867

Update a local copy of the PR:
$ git checkout pull/20867
$ git pull https://git.openjdk.org/jdk.git pull/20867/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20867

View PR using the GUI difftool:
$ git pr show -t 20867

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20867.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-09-05T10:35:27Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-09-05T10:35:42Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser

Reviewed-by: aivanov, psadhukhan, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 762 new commits pushed to the master branch:

1604255: 8341619: C2: remove unused StoreCM node
e7c5bf4: 8341722: Fix some warnings as errors when building on Linux with toolchain clang
36fca5d: 8341882: [BACKOUT] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
780de00: 8051591: Test javax/swing/JTabbedPane/8007563/Test8007563.java fails
313f4a9: 8340809: Open source few more AWT PopupMenu tests
9d621d3: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
475f8f9: 8341859: Optimize ClassFile Benchmark Write
c850ecb: 8341755: Optimize argNames in InnerClassLambdaMetafactory
172f744: 8340985: Open source some Desktop related tests
e7045e9: 8341684: Typo in External Specifications link of java.util.Currency
... and 752 more: https://git.openjdk.org/jdk/compare/6a3d045221c338fefec9bd59245324eae60b156b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-09-05T10:36:17Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-09-06T06:01:21Z

Webrevs

prsadhuk · 2024-09-06T06:12:03Z

test/jdk/javax/swing/JColorChooser/Test4887836.java

-                                then test passed, otherwise it failed.""";
+                                then test passed, otherwise it failed.
+
+                                NOTE: There is no Swatches tab for GTK Look and Feel, Press Pass.""";


I guess better to restrict programmatically
"GTK".equals(UIManager.getLookAndFeel().getName())
Also, add a comment why it is not applicable..

I guess better to restrict programmatically "GTK".equals(UIManager.getLookAndFeel().getName()) Also, add a comment why it is not applicable..

For a manual test, it can be run by command line with Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel option. How could I restrict programmatically ?

Whatever L&F you are running on irrespective of manually or automated, it should be able to find out via getLookAndFeel..

Yeah, you are right. Test updated to throw jtreg.SkippedException if it is run for GTK L&F.

TejeshR13

Looks good to me.

kumarabhi006 · 2024-09-06T10:31:46Z

@prsadhuk @TejeshR13 bug4419255.java is open sourced. Fixed similar issue for ColorChooser UI in GTK L&F.
Please re-review.

prsadhuk · 2024-09-06T11:17:56Z

test/jdk/javax/swing/plaf/basic/BasicSliderUI/bug4419255.java

+        // ColorChooser UI design is different for GTK L&F.
+        // There is no RGB tab available for GTK L&F, skip the testing.
+        if (UIManager.getLookAndFeel().getName().contains("GTK")) {
+            System.out.println("Test skipped for " + UIManager.getLookAndFeel().getName());


guess no need to enquire it again in as we know it's GTK

I think print statement is not required, anyways it is captured in exception, so removed.

prsadhuk · 2024-09-06T11:18:13Z

test/jdk/javax/swing/JColorChooser/Test4887836.java

+        // ColorChooser UI design is different for GTK L&F.
+        // There is no Swatches tab available for GTK L&F, skip the testing.
+        if (UIManager.getLookAndFeel().getName().contains("GTK")) {
+            System.out.println("Test skipped for " + UIManager.getLookAndFeel().getName());


Removed print statement here as well.

alisenchung

Since these two tests are the same test would it be better to merge them into 1 test with the test instructions combined for both tests?

TejeshR13 · 2024-09-09T05:14:10Z

test/jdk/javax/swing/plaf/basic/BasicSliderUI/bug4419255.java

+
+    private static JColorChooser createColorChooser() {
+        JColorChooser chooser = new JColorChooser(Color.BLUE);
+        return chooser;


Suggested change

return chooser;

return new JColorChooser(Color.BLUE);;

aivanov-jdk · 2024-09-17T19:31:48Z

test/jdk/javax/swing/JColorChooser/Test4887836.java

 * @bug 4887836
- * @library /java/awt/regtesthelpers
+ * @library /java/awt/regtesthelpers /test/lib
 * @build PassFailJFrame


You may explicitly mention jtreg.SkippedException in the @build tag.

Suggested change

* @build PassFailJFrame

* @build PassFailJFrame jtreg.SkippedException

Left it for now.

kumarabhi006 · 2024-10-14T04:44:25Z

/integrate

openjdk · 2024-10-14T04:45:13Z

Going to push as commit 5c4f1ef.
Since your change was applied there have been 791 commits pushed to the master branch:

41ee582: 8341138: Rename jtreg property docker.support as container.support
2e1c193: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java
2db3397: 8341797: Fix ExceptionOccurred in jdk.jdi
c4965d9: 8341794: Fix ExceptionOccurred in jdk.attach
3f53d57: 8340327: A common framework to support public key algorithms with standard parameter sets
0a57fe1: 8341178: TypeRawPtr::add_offset may be "miscompiled" due to UB
1f6bd0c: 8341972: java/awt/dnd/DnDRemoveFocusOwnerCrashTest.java timed out after JDK-8341257
7276a1b: 8341784: Refactor TypeVect to use a BasicType instead of a const Type*
6133866: 8341070: javac fails with an exception when compiling import module under source level 8
519544c: 8341909: G1: Add region index to region printer output
... and 781 more: https://git.openjdk.org/jdk/compare/6a3d045221c338fefec9bd59245324eae60b156b...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-14T04:45:20Z

@kumarabhi006 Pushed as commit 5c4f1ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Test instructions change

48ccb8c

openjdk bot added the client client-libs-dev@openjdk.org label Sep 5, 2024

kumarabhi006 changed the title ~~8226933: [TEST_BUG]GTK L&F: There is no swatches tab in JColorChooser.~~ 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser. Sep 5, 2024

kumarabhi006 changed the title ~~8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser.~~ 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser Sep 6, 2024

Whitespace error fix

e18f940

openjdk bot added the rfr Pull request is ready for review label Sep 6, 2024

prsadhuk reviewed Sep 6, 2024

View reviewed changes

Restrict test programatically for GTK L&F

56bb68d

prsadhuk approved these changes Sep 6, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2024

TejeshR13 approved these changes Sep 6, 2024

View reviewed changes

Open source test

7f98487

openjdk bot removed the ready Pull request is ready to be integrated label Sep 6, 2024

prsadhuk reviewed Sep 6, 2024

View reviewed changes

Remove print statement

677cb0e

prsadhuk approved these changes Sep 6, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2024

alisenchung reviewed Sep 6, 2024

View reviewed changes

TejeshR13 reviewed Sep 9, 2024

View reviewed changes

aivanov-jdk approved these changes Sep 17, 2024

View reviewed changes

Review comment fix

38093f2

openjdk bot removed the ready Pull request is ready to be integrated label Oct 9, 2024

PassFailJFrame default timeout and row count removed

12bf501

aivanov-jdk approved these changes Oct 10, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 14, 2024

openjdk bot closed this Oct 14, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2024

	* @build PassFailJFrame
	* @build PassFailJFrame jtreg.SkippedException

8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser #20867

8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser #20867

Uh oh!

Conversation

kumarabhi006 commented Sep 5, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Sep 5, 2024

Uh oh!

openjdk bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 5, 2024

Uh oh!

mlbridge bot commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 commented Sep 6, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alisenchung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 commented Oct 14, 2024

Uh oh!

openjdk bot commented Oct 14, 2024

Uh oh!

openjdk bot commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

kumarabhi006 commented Sep 5, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Sep 5, 2024 •

edited

Loading

mlbridge bot commented Sep 6, 2024 •

edited

Loading