Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253125 vmTestbase/nsk/stress/stack/stack017.java timed out #209

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Sep 16, 2020

Please review this small change that reduces the amount of thread stack space used by the test in order to reduce the time required to execute it. Before and after timings showed that the amount of time needed to execute the test dropped significantly with this change.

The changes to this test are similar to the changes done to test stack018.java, and others.

The modified test was run on Linux X64, MacOS, and Windows.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253125: vmTestbase/nsk/stress/stack/stack017.java timed out

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/209/head:pull/209
$ git checkout pull/209

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@hseigel The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

@dcubed-ojdk
Copy link
Member

Looks good and looks trivial.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@hseigel This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253125: vmTestbase/nsk/stress/stack/stack017.java timed out

Reviewed-by: dcubed
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate d250f9e08c4a0c047cd3e619918c116f568e31d4.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2020
@hseigel
Copy link
Member Author

hseigel commented Sep 16, 2020

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@hseigel Pushed as commit ce93cbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants