Skip to content

8339703: Problem list serviceability/sa/TestJhsdbJstackUpcall.java for generational ZGC #20902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Sep 7, 2024

This is a new SA test. We don't support SA with generational ZGC, so the test needs to be problem listed.

I'd like to push this as a trivial change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339703: Problem list serviceability/sa/TestJhsdbJstackUpcall.java for generational ZGC (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20902/head:pull/20902
$ git checkout pull/20902

Update a local copy of the PR:
$ git checkout pull/20902
$ git pull https://git.openjdk.org/jdk.git pull/20902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20902

View PR using the GUI difftool:
$ git pr show -t 20902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20902.diff

Webrev

Link to Webrev Comment

@plummercj
Copy link
Contributor Author

/label add serviceability

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2024

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 7, 2024

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339703: Problem list serviceability/sa/TestJhsdbJstackUpcall.java for generational ZGC

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8339703 8339703: Problem list serviceability/sa/TestJhsdbJstackUpcall.java for generational ZGC Sep 7, 2024
@openjdk openjdk bot added rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org labels Sep 7, 2024
@openjdk
Copy link

openjdk bot commented Sep 7, 2024

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 7, 2024

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pl's are trivial.

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2024
@plummercj
Copy link
Contributor Author

Thanks David!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2024

Going to push as commit f0e84b7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2024
@openjdk openjdk bot closed this Sep 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2024
@openjdk
Copy link

openjdk bot commented Sep 7, 2024

@plummercj Pushed as commit f0e84b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants