New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues #2091
Conversation
…ompilation issues
👋 Welcome back sundar! A progress list of the required criteria for merging this PR into |
@sundararajana The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Are you going to remove it from the exclude list (test/jdk/ProblemList.txt)? I skimmed through the changes and it looks fine but would like confirmation that it has been run many times on all platforms (some of the jlink tests have taken time to get stable). |
@sundararajana This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 230 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@sundararajana Since your change was applied there have been 230 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit c0cde7d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Note the test has been added back to the ProblemList due to failures in the CI. |
Fixed compilation issues with the test. Test compiles and runs fine locally.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2091/head:pull/2091
$ git checkout pull/2091