Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues #2091

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter
Filter file types
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -781,7 +781,6 @@ sanity/client/SwingSet/src/ScrollPaneDemoTest.java 8225013 linux-all

tools/jlink/JLinkReproducibleTest.java 8217166 windows-all,linux-aarch64
tools/jlink/JLinkReproducible3Test.java 8253688 linux-aarch64
tools/jlink/plugins/CompressorPluginTest.java 8247407 generic-all

############################################################################

@@ -95,17 +95,19 @@ public void test() throws Exception {

// compress level 0 == no compression
Properties options0 = new Properties();
options0.setProperty(DefaultCompressPlugin.NAME,
"0");
checkCompress(classes, new DefaultCompressPlugin(),
DefaultCompressPlugin compressPlugin = new DefaultCompressPlugin();
options0.setProperty(compressPlugin.getName(),
DefaultCompressPlugin.LEVEL_0);
checkCompress(classes, compressPlugin,
options0,
new ResourceDecompressorFactory[]{
});

// compress level 1 == String sharing
Properties options1 = new Properties();
options1.setProperty(DefaultCompressPlugin.NAME, "1");
checkCompress(classes, new DefaultCompressPlugin(),
compressPlugin = new DefaultCompressPlugin();
options1.setProperty(compressPlugin.getName(), DefaultCompressPlugin.LEVEL_1);
checkCompress(classes, compressPlugin,
options1,
new ResourceDecompressorFactory[]{
new StringSharingDecompressorFactory()
@@ -114,8 +116,9 @@ public void test() throws Exception {
// compress level 1 == String sharing + filter
options1.setProperty(DefaultCompressPlugin.FILTER,
"**Exception.class");
options1.setProperty(DefaultCompressPlugin.NAME, "1");
checkCompress(classes, new DefaultCompressPlugin(),
compressPlugin = new DefaultCompressPlugin();
options1.setProperty(compressPlugin.getName(), DefaultCompressPlugin.LEVEL_1);
checkCompress(classes, compressPlugin,
options1,
new ResourceDecompressorFactory[]{
new StringSharingDecompressorFactory()
@@ -125,8 +128,9 @@ public void test() throws Exception {
Properties options2 = new Properties();
options2.setProperty(DefaultCompressPlugin.FILTER,
"**Exception.class");
options2.setProperty(DefaultCompressPlugin.NAME, "2");
checkCompress(classes, new DefaultCompressPlugin(),
compressPlugin = new DefaultCompressPlugin();
options2.setProperty(compressPlugin.getName(), DefaultCompressPlugin.LEVEL_2);
checkCompress(classes, compressPlugin,
options2,
new ResourceDecompressorFactory[]{
new ZipDecompressorFactory()
@@ -135,8 +139,9 @@ public void test() throws Exception {
// compress level 2 == ZIP + filter
options2.setProperty(DefaultCompressPlugin.FILTER,
"**Exception.class");
options2.setProperty(DefaultCompressPlugin.NAME, "2");
checkCompress(classes, new DefaultCompressPlugin(),
compressPlugin = new DefaultCompressPlugin();
options2.setProperty(compressPlugin.getName(), DefaultCompressPlugin.LEVEL_2);
checkCompress(classes, compressPlugin,
options2,
new ResourceDecompressorFactory[]{
new ZipDecompressorFactory(),
ProTip! Use n and p to navigate between commits in a pull request.