Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339781: Better use of Javadoc tags in javax.lang.model #20917

Closed
wants to merge 4 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Sep 9, 2024

More extensive use of definition HTML tag and index javadoc tag.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339781: Better use of Javadoc tags in javax.lang.model (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20917/head:pull/20917
$ git checkout pull/20917

Update a local copy of the PR:
$ git checkout pull/20917
$ git pull https://git.openjdk.org/jdk.git pull/20917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20917

View PR using the GUI difftool:
$ git pr show -t 20917

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20917.diff

Webrev

Link to Webrev Comment

@jddarcy jddarcy marked this pull request as draft September 9, 2024 15:50
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2024

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 9, 2024

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339781: Better use of Javadoc tags in javax.lang.model

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 64275e6: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems
  • 5cffddc: 8338471: Assert deleted methods not returned by CallInfo
  • 40fba14: 8340232: Optimize DataInputStream::readUTF

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8339781: Better use of Javadoc tags in javax.lang.model 8339781: Better use of Javadoc tags in javax.lang.model Sep 9, 2024
@openjdk
Copy link

openjdk bot commented Sep 9, 2024

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Sep 9, 2024
@jddarcy jddarcy marked this pull request as ready for review September 20, 2024 19:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2024
@jddarcy
Copy link
Member Author

jddarcy commented Sep 20, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

Going to push as commit 08b2561.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 64275e6: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems
  • 5cffddc: 8338471: Assert deleted methods not returned by CallInfo
  • 40fba14: 8340232: Optimize DataInputStream::readUTF

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2024
@openjdk openjdk bot closed this Sep 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@jddarcy Pushed as commit 08b2561.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8339781 branch October 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants