Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256110: Create implementation for NSAccessibilityStepper protocol #2092

Closed
wants to merge 3 commits into from

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Jan 15, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256110: Create implementation for NSAccessibilityStepper protocol

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2092/head:pull/2092
$ git checkout pull/2092

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 15, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

⚠️ @azuev-java This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

@azuev-java The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 15, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256110: Create implementation for NSAccessibilityStepper protocol

Reviewed-by: pbansal, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5f2e280: 8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 15, 2021
@@ -40,17 +40,7 @@ - (nullable NSString *)accessibilityLabel

- (BOOL)accessibilityPerformPress
{
AWT_ASSERT_APPKIT_THREAD;
Copy link
Member

@mrserb mrserb Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to remove the static "jclass sjc_CAccessibility = NULL;" above as well?

Copy link
Member Author

@azuev-java azuev-java Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And unneeded imports too. Remnants of the code that is gone. Fixed.

mrserb
mrserb approved these changes Jan 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 17, 2021

@azuev-java this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8256110
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict and removed ready labels Jan 17, 2021
azuev-java added 3 commits Jan 17, 2021
Initial implementation. Also i have moved AccessibilityAction code into
the common layer so it can be easier accessible from other Action
related components without much duplication.
@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Jan 17, 2021

/integrate

@openjdk openjdk bot closed this Jan 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 17, 2021

@azuev-java Since your change was applied there has been 1 commit pushed to the master branch:

  • 5f2e280: 8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13

Your commit was automatically rebased without conflicts.

Pushed as commit 5dc5d94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@azuev-java azuev-java deleted the JDK-8256110 branch Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants