-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8225049: Bad -Xlog example in -Xlog:help, online documentation, JEP #20934
Conversation
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@jaikiran To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and trivial
Thanks
It looks like the -Xlog:help output was already fixed. |
Thank you for the review David.
Right, as you already found out, it got fixed in https://bugs.openjdk.org/browse/JDK-8215398. |
/integrate |
Going to push as commit 0764323.
Your commit was automatically rebased without conflicts. |
Can I get a review of this change which fixes a typo in the java spec documentation?
As noted in the issue, the example used there
-Xlog:gc=trace:file=gctrace.txt:uptimemillis,pids:filecount=5,filesize=1024
doesn't work and instead ofpids
, it should have beenpid
.The updated example in this PR now works fine with:
java -Xlog:gc=trace:file=gctrace.txt:uptimemillis,pid:filecount=5,filesize=1024 -version
and the generated trace file contains the process id:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20934/head:pull/20934
$ git checkout pull/20934
Update a local copy of the PR:
$ git checkout pull/20934
$ git pull https://git.openjdk.org/jdk.git pull/20934/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20934
View PR using the GUI difftool:
$ git pr show -t 20934
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20934.diff