8339560: Unaddressed comments during code review of JDK-8337664

[fguallini]

During the code review of JDK-8337664, several non-critical comments were raised but not addressed due to time constraints. This PR includes the following changes:

1. Symantec and Entrust tests now reuse common code. The Distrust.java class contains this reusable code, making it easier to add new tests for distrusted roots in the future.
2. In several instances where an Exception is thrown, it has been replaced with RuntimeException.
3. Many Symantec test certs have already expired. To properly test the distrusted scenario, this change wraps the intermediate and root CA certs in NonExpiringTLSServerCert, which does not validate expiration.
4. Package structure changed:

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339560: Unaddressed comments during code review of JDK-8337664 (Bug - P4)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20944/head:pull/20944
$ git checkout pull/20944

Update a local copy of the PR:
$ git checkout pull/20944
$ git pull https://git.openjdk.org/jdk.git pull/20944/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20944

View PR using the GUI difftool:
$ git pr show -t 20944

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20944.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339560: Unaddressed comments during code review of JDK-8337664

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 222 new commits pushed to the master branch:

• fb70325: 8338583: NMT: Malloc overhead is calculated incorrectly
• 083b980: 8340568: Incorrect escaping of single quotes when pretty-printing character literals
• d8790aa: 8340885: Desugar ZipCoder.Comparison
• 120463d: 8339541: CSS rule is not specific enough
• 1b9898a: 8340843: [PPC64/s390x] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694
• 9806d21: 8340808: RISC-V: Client build fails after JDK-8339738
• 97a3933: 8339771: RISC-V: Reduce icache flushes
• b1f8d2e: 8339935: Open source several AWT focus tests - series 5
• 2e0554a: 8340710: Optimize DirectClassBuilder::build
• 2d38af6: 8340587: Optimize StackMapGenerator$Frame::checkAssignableTo
• ... and 212 more: https://git.openjdk.org/jdk/compare/125f743223f2beb6e73f520c48a9a2de7ba5dce7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fguallini The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7e7a30f9)

[seanjmullan]

Do you need /test/lib anymore?

[fguallini]

Yes, it won't compile otherwise because the helper class Distrusts still needs to import jdk.test.lib.security.SecurityUtils.

[seanjmullan]

Looks good.

[fguallini]

/integrate

[openjdk]

@fguallini
Your change (at version 7e7a30f) is now ready to be sponsored by a Committer.

[seanjmullan]

/sponsor

[openjdk]

Going to push as commit 95d3e9d.
Since your change was applied there have been 238 commits pushed to the master branch:

• 47fcf5a: 8340687: Open source closed frame tests Azure Pipelines continuous integration (without running tests, for now) #1
• 777c20c: 8339542: compiler/codecache/CheckSegmentedCodeCache.java fails
• 3762ec3: 8340466: Add description for PassFailJFrame constructors
• e2626db: 8340899: Remove wildcard bound in PositionWindows.positionTestWindows
• 10da2c2: 8340923: The class LogSelection copies uninitialized memory
• 8c8f0d8: 8339260: Move rarely used constants out of ClassFile
• 47c1069: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe
• 66f1639: 8339271: giflib attribution correction
• 8f75619: 8340864: Remove unused lines related to vmClasses
• 84751cb: 8340831: Simplify simple validation for class definition in MethodHandles.Lookup
• ... and 228 more: https://git.openjdk.org/jdk/compare/125f743223f2beb6e73f520c48a9a2de7ba5dce7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@seanjmullan @fguallini Pushed as commit 95d3e9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.