Skip to content

8339939: [JVMCI] Don't compress abstract and interface Klasses #20949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Sep 11, 2024

#19157 disallows storing abstract and interface Klasses in class metaspace. JVMCI has to respect this and avoids compressing abstract and interface Klasses


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339939: [JVMCI] Don't compress abstract and interface Klasses (Bug - P4)

Reviewers

Contributors

  • Doug Simon <dnsimon@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20949/head:pull/20949
$ git checkout pull/20949

Update a local copy of the PR:
$ git checkout pull/20949
$ git pull https://git.openjdk.org/jdk.git pull/20949/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20949

View PR using the GUI difftool:
$ git pr show -t 20949

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20949.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2024

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339939: [JVMCI] Don't compress abstract and interface Klasses

Co-authored-by: Doug Simon <dnsimon@openjdk.org>
Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 167 new commits pushed to the master branch:

  • a5ad974: 8343056: C2: Micro-optimize Node lists grow
  • ec06187: 8034066: Incorrect alignment in the "Code" section for "-c -XDdetails" options
  • eb3669a: 8340796: Use a consistent order when loading cxq and EntryList
  • 0e3fc93: 8342083: Make a few fields in FileSystemPreferences final
  • 762a573: 8335880: More troubleshooting tips around windows space in path
  • 40e07a7: 8342865: Use type parameter for Class::getPrimitiveClass
  • 9e451aa: 8343102: Remove --compress from jlink command lines from jpackage tests
  • 873f8a6: 8305406: Add @SPEC tags in java.base/java.* (part 2)
  • 1476f6c: 8343030: RISC-V: Small assembler cleanups
  • f1a9a8d: 8342902: Deduplication of acquire calls in BindingSpecializer causes escape-analyisis failure
  • ... and 157 more: https://git.openjdk.org/jdk/compare/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Sep 11, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 11, 2024
@mur47x111
Copy link
Contributor Author

/contributor add @dougxc

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@mur47x111
Contributor Doug Simon <dnsimon@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 11, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 11, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

@mur47x111 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 16, 2024
Copy link
Member

@dougxc dougxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2024
@mur47x111
Copy link
Contributor Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2024

Going to push as commit d5fb6b4.
Since your change was applied there have been 167 commits pushed to the master branch:

  • a5ad974: 8343056: C2: Micro-optimize Node lists grow
  • ec06187: 8034066: Incorrect alignment in the "Code" section for "-c -XDdetails" options
  • eb3669a: 8340796: Use a consistent order when loading cxq and EntryList
  • 0e3fc93: 8342083: Make a few fields in FileSystemPreferences final
  • 762a573: 8335880: More troubleshooting tips around windows space in path
  • 40e07a7: 8342865: Use type parameter for Class::getPrimitiveClass
  • 9e451aa: 8343102: Remove --compress from jlink command lines from jpackage tests
  • 873f8a6: 8305406: Add @SPEC tags in java.base/java.* (part 2)
  • 1476f6c: 8343030: RISC-V: Small assembler cleanups
  • f1a9a8d: 8342902: Deduplication of acquire calls in BindingSpecializer causes escape-analyisis failure
  • ... and 157 more: https://git.openjdk.org/jdk/compare/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2024
@openjdk openjdk bot closed this Oct 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2024
@openjdk
Copy link

openjdk bot commented Oct 28, 2024

@mur47x111 Pushed as commit d5fb6b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants