-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8339939: [JVMCI] Don't compress abstract and interface Klasses #20949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into |
@mur47x111 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 167 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@mur47x111 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/contributor add @dougxc |
@mur47x111 |
Webrevs
|
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotConstant.java
Show resolved
Hide resolved
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotConstant.java
Show resolved
Hide resolved
@mur47x111 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good.
Thanks! /integrate |
Going to push as commit d5fb6b4.
Your commit was automatically rebased without conflicts. |
@mur47x111 Pushed as commit d5fb6b4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
#19157 disallows storing abstract and interface Klasses in class metaspace. JVMCI has to respect this and avoids compressing abstract and interface Klasses
Progress
Issue
Reviewers
Contributors
<dnsimon@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20949/head:pull/20949
$ git checkout pull/20949
Update a local copy of the PR:
$ git checkout pull/20949
$ git pull https://git.openjdk.org/jdk.git pull/20949/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20949
View PR using the GUI difftool:
$ git pr show -t 20949
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20949.diff
Webrev
Link to Webrev Comment