8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java

[manukumarvs]

Stabilized the test by disposing the frame at the end, adding an auto delay, called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, etc
And for better debugging, added captureScreen() for failure cases.

Testing:
Tested using mach5 in all available platforms and attached the link in bug as a comment.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java (Bug - P4)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer) Review applies to 6238ba9b
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20951/head:pull/20951
$ git checkout pull/20951

Update a local copy of the PR:
$ git checkout pull/20951
$ git pull https://git.openjdk.org/jdk.git pull/20951/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20951

View PR using the GUI difftool:
$ git pr show -t 20951

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20951.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java

Reviewed-by: prr, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• fdfe503: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms
• 3aa8338: 8340075: Autoconf bundle cannot run on read-only filesystem
• 37bf589: 8339847: Broken link to the dieharder distribution website in SplittableRandom
• 89c172a: 8340082: Use inline return tag in java.base
• 1a0a538: 8340120: Remove redundant code in SegmentBulkOperations::mismatch
• 89ca89c: 8338626: ClassLoaderExt::process_jar_manifest() should allow / separator on Windows
• 3e0da58: 8333843: Provide guidelines on MemorySegment to read strings with known lengths
• 3c4d15b: 8334301: Errors in jpackage man page
• 4d01178: 8339927: Man page update for deprecating jhsdb debugd for removal
• bd44cf8: 8330302: strace004 can still fail
• ... and 28 more: https://git.openjdk.org/jdk/compare/55a7cf14453b6cd1de91362927b2fa63cba400a1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azvegint, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b4758cd7)
• 01: Full - Incremental (6238ba9b)
• 00: Full (4343f4db)

[azvegint]

My other comments are minor, because this changeset doesn't seem to help, if we increase the JTREG=REPEAT_COUNT from 10 to 100 it can still timeout on Windows.

[manukumarvs]

My other comments are minor, because this changeset doesn't seem to help, if we increase the JTREG=REPEAT_COUNT from 10 to 100 it can still timeout on Windows.

With the new changes, I have run it 900 times(JTREG=REPEAT_COUNT=100 in 9 machines) in windows as well as 100 times each on other platforms and no failures observed(mach5 test links are attached in bug).

[azvegint]

Thank you, looks good, except for minor formatting issues.

[manukumarvs]

/integrate auto

[openjdk]

@manukumarvs This pull request will be automatically integrated when it is ready

[manukumarvs]

@azvegint I have made the formatting corrections suggested by you, can you please re-review the PR as the new process requires a re-review if any changes made after the approval.

[azvegint]

@azvegint I have made the formatting corrections suggested by you, can you please re-review the PR as the new process requires a re-review if any changes made after the approval.

I saw it, and it's fine, I'll just give someone else more time to review it if they want to.

[openjdk]

/integrate

[openjdk]

@openjdk[bot]
Your change (at version b4758cd) is now ready to be sponsored by a Committer.

[azvegint]

/sponsor

[openjdk]

Going to push as commit fa502ec.
Since your change was applied there have been 38 commits pushed to the master branch:

• fdfe503: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms
• 3aa8338: 8340075: Autoconf bundle cannot run on read-only filesystem
• 37bf589: 8339847: Broken link to the dieharder distribution website in SplittableRandom
• 89c172a: 8340082: Use inline return tag in java.base
• 1a0a538: 8340120: Remove redundant code in SegmentBulkOperations::mismatch
• 89ca89c: 8338626: ClassLoaderExt::process_jar_manifest() should allow / separator on Windows
• 3e0da58: 8333843: Provide guidelines on MemorySegment to read strings with known lengths
• 3c4d15b: 8334301: Errors in jpackage man page
• 4d01178: 8339927: Man page update for deprecating jhsdb debugd for removal
• bd44cf8: 8330302: strace004 can still fail
• ... and 28 more: https://git.openjdk.org/jdk/compare/55a7cf14453b6cd1de91362927b2fa63cba400a1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint @manukumarvs Pushed as commit fa502ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.