8319875: Add macOS implementation for jcmd System.map

[stooke]

This is a port of #16301 to macOS.

System.map and System.dump_map are implemented using the macOS API and provide roughly the same information in the same format. Most of the heavy lifting was implemented by @tstuefe in #16301 - this PR adds the macOS implementation and enables the common code for macOS 64 bit.

The System.map tests are also reworked to be cleaner for the three implementations.

sample output using G1GC
sample output using ZGC

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319875: Add macOS implementation for jcmd System.map (Enhancement - P4)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Sonia Zaldana Calles (@SoniaZaldana - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20953/head:pull/20953
$ git checkout pull/20953

Update a local copy of the PR:
$ git checkout pull/20953
$ git pull https://git.openjdk.org/jdk.git pull/20953/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20953

View PR using the GUI difftool:
$ git pr show -t 20953

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20953.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stooke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stooke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319875: Add macOS implementation for jcmd System.map

Reviewed-by: stuefe, szaldana

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• 266e3d0: 8345590: AIX 'make all' fails after JDK-8339480
• 1d2ccae: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64
• a9a5f7c: 8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully
• 367c304: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17
• 31ceec7: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04
• 09c29d1: 8346069: Add missing Classpath exception statements
• 28e49e9: 8345505: Fix -Wzero-as-null-pointer-constant warnings in zero code
• db9eab3: 8311542: Consolidate the native stack printing code
• 18e0b34: 8344137: Update XML Security for Java to 3.0.5
• e9ad27f: 8339313: 32-bit build broken
• ... and 55 more: https://git.openjdk.org/jdk/compare/a6277bb521e07e569cd75a4641b2a05a26f47b0a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @SoniaZaldana) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@stooke The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[AlanBateman]

/label remove core-libs

[openjdk]

@AlanBateman
The core-libs label was successfully removed.

[openjdk]

@stooke this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout pr_macos_system_dump
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[stooke]

@tstuefe , I've actually added the combining code here, and reconfirmed that both the System.map and System.dump_map tests pass on my arm M2, and an ancient x86_64 Macbook.

[tstuefe]

Okay!

Needs a second review. @ashu-mehra, maybe?

[tstuefe]

BTW make sure you merge and test again before integrating. Your branch is quite old. In fact, you should merge upstream often (The rule with merge vs rebase is: you merge after the patch has been un-drafted und RFR mail has been set out; before that, you can rebase).

[stooke]

@tstuefe it looks like the aarch64 runner has been fixed. After merging, all tests have passed.

[SoniaZaldana]

I am not a Reviewer but this looks good to me. I left a small comment inline. Thanks Simon!

[tstuefe]

Still good. Ship it!

[stooke]

/integrate

[openjdk]

@stooke
Your change (at version c5cb0f9) is now ready to be sponsored by a Committer.

[tstuefe]

/sponsor

[openjdk]

Going to push as commit 3b9de11.
Since your change was applied there have been 72 commits pushed to the master branch:

• ebb27c2: 8346139: test_memset_with_concurrent_readers.cpp should not use
• c2f0ef5: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635
• 4b21fb9: 8343467: Remove unnecessary @SuppressWarnings annotations (security)
• e7fc0eb: 8345987: java.management has two Util.newObjectName methods (remove one)
• f647d4d: 8345936: Call ClassLoader.getResourceAsByteArray only for multi-release jar
• cfa04d3: 8346051: MemoryTest fails when Shenandoah's generational mode is enabled
• 2ce53e8: 8345970: pthread_getcpuclockid related crashes in shenandoah tests
• 266e3d0: 8345590: AIX 'make all' fails after JDK-8339480
• 1d2ccae: 8345569: [ubsan] adjustments to filemap.cpp and virtualspace.cpp for macOS aarch64
• a9a5f7c: 8345323: Parallel GC does not handle UseLargePages and UseNUMA gracefully
• ... and 62 more: https://git.openjdk.org/jdk/compare/a6277bb521e07e569cd75a4641b2a05a26f47b0a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe @stooke Pushed as commit 3b9de11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.