Skip to content

Conversation

@offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Sep 12, 2024

This PR will ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java on s390x. This change should be reverted while fixing JDK-8339216.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20960/head:pull/20960
$ git checkout pull/20960

Update a local copy of the PR:
$ git checkout pull/20960
$ git pull https://git.openjdk.org/jdk.git pull/20960/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20960

View PR using the GUI difftool:
$ git pr show -t 20960

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20960.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

  • 08a2f84: 8339738: RISC-V: Vectorize crc32 intrinsic
  • 1d070a3: 8337302: Undefined type variable results in null
  • aeba1ea: 8340272: C2 SuperWord: JMH benchmark for Reduction vectorization
  • 19b2cee: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view)
  • 45e438f: 8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP
  • 4ff17c1: 8319873: Add windows implementation for jcmd System.map and System.dump_map
  • 3895b8f: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
  • 5381f55: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences()
  • d23c59e: 8340280: Avoid calling MT.invokerType() when creating LambdaForms
  • 147e300: 8340015: Open source several AWT focus tests - series 7
  • ... and 71 more: https://git.openjdk.org/jdk/compare/6d4bd6c6b6c3e6ef4c0a1e4eebf888156e43da58...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8339980 8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java Sep 12, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@offamitkumar To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@offamitkumar
Copy link
Member Author

/label add core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@offamitkumar
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 12, 2024

Webrevs

@offamitkumar
Copy link
Member Author

@RealLucy can you have a quick look at this one ? It's trivial change.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2024
@offamitkumar
Copy link
Member Author

Thank you @RealLucy :-)

/integrate

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

Going to push as commit 537447f.
Since your change was applied there have been 88 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2024
@openjdk openjdk bot closed this Sep 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2024
@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@offamitkumar Pushed as commit 537447f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@offamitkumar offamitkumar deleted the problemList_closeInflater_deflater branch September 19, 2024 04:34
@jaikiran
Copy link
Member

Hello Amit, following the process noted at https://openjdk.org/guide/#problemlisting-jtreg-tests for problem listing, I have now added the problemlist label to https://bugs.openjdk.org/browse/JDK-8339216.

@offamitkumar
Copy link
Member Author

Hi @jaikiran,

Just went through that guide.

Remember to always add a problemlist label in the JBS issue referenced in the ProblemList entry.

Sorry, I didn't know it. Thank for pointing it out. I will follow it in future :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants