Skip to content

8334301: Errors in jpackage man page#20969

Closed
alexeysemenyukoracle wants to merge 1 commit intoopenjdk:masterfrom
alexeysemenyukoracle:JDK-8334301
Closed

8334301: Errors in jpackage man page#20969
alexeysemenyukoracle wants to merge 1 commit intoopenjdk:masterfrom
alexeysemenyukoracle:JDK-8334301

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Sep 12, 2024

Correct jpackage man errors


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20969/head:pull/20969
$ git checkout pull/20969

Update a local copy of the PR:
$ git checkout pull/20969
$ git pull https://git.openjdk.org/jdk.git pull/20969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20969

View PR using the GUI difftool:
$ git pr show -t 20969

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20969.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334301: Errors in jpackage man page

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

  • 81ff91e: 8339531: Improve performance of MemorySegment::mismatch
  • ab9b72c: 8329035: New Data Destination instructions support
  • 7f1dae1: 8339874: Avoid duplicate checking of trailing slash in ZipFile.getZipEntry
  • 4d65c3e: 8339876: Move constant symbol caches to Utf8EntryImpl
  • 0765917: 8340011: Simplify jdk.internal.classfile.impl.EntryMap
  • 1b17e0b: 8338747: hasIncubatorModules needs to be generated when module resolution required at startup
  • 3c40afa: 8334165: Remove serialVersionUID compatibility logic from JMX
  • 315abdf: 8339733: C2: some nodes can have incorrect control after do_range_check()
  • ac3f92b: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings
  • cfbf74f: 8339159: api/java_rmi/Naming/Rebind.html crashes with SEGV from UTF8::quoted_ascii_length call
  • ... and 76 more: https://git.openjdk.org/jdk/compare/b389bb456726184e4691777b1bb02d4b8a8a3f97...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8334301: Errors in jpackage man page 8334301: Errors in jpackage man page Sep 12, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 12, 2024
@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev please review

@mlbridge
Copy link

mlbridge bot commented Sep 12, 2024

Webrevs

@sashamatveev
Copy link
Member

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2024
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

Going to push as commit 3c4d15b.
Since your change was applied there have been 96 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2024
@openjdk openjdk bot closed this Sep 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2024
@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@alexeysemenyukoracle Pushed as commit 3c4d15b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8334301 branch November 9, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants