8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior

[kdnilsen]

This fixes some bugs found in recent code review and playback of an assertion failure.

See also openjdk/shenandoah#497

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior (Bug - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

• William Kemper (@earthling-amzn - Committer)
• Roman Kennke (@rkennke - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20974/head:pull/20974
$ git checkout pull/20974

Update a local copy of the PR:
$ git checkout pull/20974
$ git pull https://git.openjdk.org/jdk.git pull/20974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20974

View PR using the GUI difftool:
$ git pr show -t 20974

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20974.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior

Reviewed-by: wkemper, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 65b9aba: 8339769: Incorrect error message during startup if working directory does not exist
• 1640bd2: 8340186: Shenandoah: Missing load_reference_barrier_phantom_narrow match in is_shenandoah_lrb_call
• 996790c: 8339954: Print JVMCI names with the Compiler.{perfmap,codelist,CodeHeap_Analytics} diagnostic commands
• e1ebeef: 8340131: Refactor internal makeHiddenClassDefiner to take option mask instead of Set
• 05b9d47: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file
• 5459518: 8339627: Cleanup Unsafe.setMemory intrinsic code
• a4eb9a0: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher
• 6be15c3: 8340012: [C2] assert(KlassEncodingMetaspaceMax > pd) failed: change encoding max if new encoding after 8338526
• 4b79063: 8339842: Open source several AWT focus tests - series 2
• dc00eb8: 8338912: CDS: Segmented roots array
• ... and 24 more: https://git.openjdk.org/jdk/compare/81ff91ef27a6a856ae2c453a9a9b8333b91da3ab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@earthling-amzn, @rkennke) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@kdnilsen The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f1ba63f4)

[earthling-amzn]

Looks good to me.

[rkennke]

Looks good, thanks!

[kdnilsen]

/integrate

[openjdk]

@kdnilsen
Your change (at version f1ba63f) is now ready to be sponsored by a Committer.

[ysramakrishna]

/sponsor

[openjdk]

Going to push as commit 858b4f1.
Since your change was applied there have been 36 commits pushed to the master branch:

• 59407fa: 8310525: DynamicLauncher for JDP test needs to try harder to find a free port
• 89759c8: 8321935: Define the term 'standard doclet'
• 65b9aba: 8339769: Incorrect error message during startup if working directory does not exist
• 1640bd2: 8340186: Shenandoah: Missing load_reference_barrier_phantom_narrow match in is_shenandoah_lrb_call
• 996790c: 8339954: Print JVMCI names with the Compiler.{perfmap,codelist,CodeHeap_Analytics} diagnostic commands
• e1ebeef: 8340131: Refactor internal makeHiddenClassDefiner to take option mask instead of Set
• 05b9d47: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file
• 5459518: 8339627: Cleanup Unsafe.setMemory intrinsic code
• a4eb9a0: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher
• 6be15c3: 8340012: [C2] assert(KlassEncodingMetaspaceMax > pd) failed: change encoding max if new encoding after 8338526
• ... and 26 more: https://git.openjdk.org/jdk/compare/81ff91ef27a6a856ae2c453a9a9b8333b91da3ab...master

Your commit was automatically rebased without conflicts.

[openjdk]

@ysramakrishna @kdnilsen Pushed as commit 858b4f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.