8330302: strace004 can still fail

[dholmes-ora]

This is a trivial point fix for the strace tests to add in the missing event (super)constructors. These tests have started failing more regularly after the Thread.sleep code was recently changed.

The fragility of these tests is well known but I simply want to deal with current failures in our CI. It remains a future RFE to fix these tests so they don't need continual updating like this.

Testing:

• themselves
• tier 5 (which is where we see CI failures most often)

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330302: strace004 can still fail (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20980/head:pull/20980
$ git checkout pull/20980

Update a local copy of the PR:
$ git checkout pull/20980
$ git pull https://git.openjdk.org/jdk.git pull/20980/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20980

View PR using the GUI difftool:
$ git pr show -t 20980

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20980.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330302: strace004 can still fail

Reviewed-by: alanb, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 0c36177: 8340089: Simplify SegmentBulkOperations::powerOfProperty
• bacd046: 8321010: RISC-V: C2 RoundVF
• 5709c37: 8340081: Test java/foreign/TestLinker.java failed failed: missing permission java.lang.foreign.native.threshold.power.fill
• b88ff9c: 8339849: Enumerate opto and C1 stubs, generate enums, names, fields and generator calls
• ae75ca0: 8314842: zgc/genzgc tests ignore vm flags
• 5e5942a: 8339794: Open source closed choice tests Azure Pipelines continuous integration (without running tests, for now) #1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (cd6ae800)
• 00: Full (8930ed4a)

[AlanBateman]

So no change to test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/ThreadController.java and test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/thread/SleepingThread.java this time?

Is there a JBS issue to re-write these tests?

[dholmes-ora]

Thanks for the review @AlanBateman . You are right the others should be updated too even though we have never seen the constructor appear in those cases.

I couldn't find a JBS issue so filed JDK-8340088

[dholmes-ora]

Thanks for the reviews @AlanBateman and @shipilev !

/integrate

[openjdk]

Going to push as commit bd44cf8.
Since your change was applied there have been 8 commits pushed to the master branch:

• 8a4ea09: 8336492: Regression in lambda serialization
• 358ff19: 8339727: Open source several AWT focus tests - series 1
• 0c36177: 8340089: Simplify SegmentBulkOperations::powerOfProperty
• bacd046: 8321010: RISC-V: C2 RoundVF
• 5709c37: 8340081: Test java/foreign/TestLinker.java failed failed: missing permission java.lang.foreign.native.threshold.power.fill
• b88ff9c: 8339849: Enumerate opto and C1 stubs, generate enums, names, fields and generator calls
• ae75ca0: 8314842: zgc/genzgc tests ignore vm flags
• 5e5942a: 8339794: Open source closed choice tests Azure Pipelines continuous integration (without running tests, for now) #1

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit bd44cf8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[viktorklang-ora]

Nice work, thanks @dholmes-ora!