Skip to content

8340105: Expose BitMap::print_on in release builds #20995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 13, 2024

A small quality of life improvement. This irritates me often enough when I am looking at various bitmaps in release builds. BitMap::print_on is not available in release builds, and bitmaps in debug builds are sometimes different than the ones in release builds. This often forces me to do additional hack to expose it. I think it should just be available in release builds to begin with.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340105: Expose BitMap::print_on in release builds (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20995/head:pull/20995
$ git checkout pull/20995

Update a local copy of the PR:
$ git checkout pull/20995
$ git pull https://git.openjdk.org/jdk.git pull/20995/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20995

View PR using the GUI difftool:
$ git pr show -t 20995

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20995.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340105: Expose BitMap::print_on in release builds

Reviewed-by: stuefe, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2024
@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 13, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2024

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2024
Copy link
Member

@stefank stefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2024

Going to push as commit 74add0e.
Since your change was applied there have been 41 commits pushed to the master branch:

  • 0e0f10f: 8340102: Move assert-only loop in OopMapSort::sort under debug macro
  • a0794e0: 8339639: Opensource few AWT PopupMenu tests
  • a8f143c: 8306679: com/sun/jdi/InterruptHangTest.java asserts with -Xcomp -Dmain.wrapper=Virtual options
  • c91fa27: 8339725: Concurrent GC crashed due to GetMethodDeclaringClass
  • fa502ec: 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java
  • fdfe503: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms
  • 3aa8338: 8340075: Autoconf bundle cannot run on read-only filesystem
  • 37bf589: 8339847: Broken link to the dieharder distribution website in SplittableRandom
  • 89c172a: 8340082: Use inline return tag in java.base
  • 1a0a538: 8340120: Remove redundant code in SegmentBulkOperations::mismatch
  • ... and 31 more: https://git.openjdk.org/jdk/compare/d9fdf69c34c20e0f2d526c2f04450acb904c3e80...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2024
@openjdk openjdk bot closed this Sep 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2024
@openjdk
Copy link

openjdk bot commented Sep 16, 2024

@shipilev Pushed as commit 74add0e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8340105-expose-bitmap-print-on branch January 8, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants