8340119: Remove oopDesc::size_might_change()

[tschatzl]

Hi all,

please review this change that removes oopDesc::size_might_change() because since JDK-8337709 and JDK-8311163 no collector uses the objArray's length field during garbage collection any more.

Testing: tier1-3

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340119: Remove oopDesc::size_might_change() (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20999/head:pull/20999
$ git checkout pull/20999

Update a local copy of the PR:
$ git checkout pull/20999
$ git pull https://git.openjdk.org/jdk.git pull/20999/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20999

View PR using the GUI difftool:
$ git pr show -t 20999

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20999.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340119: Remove oopDesc::size_might_change()

Reviewed-by: stefank, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• a4cf191: 8339793: Fix incorrect APX feature enabling with -XX:-UseAPX
• 3e03e66: 8340176: Replace usage of -noclassgc with -Xnoclassgc in test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.java
• 99d7185: 8340144: C1: remove unused Compilation::_max_spills
• 418bb42: 8340073: Support "%z" time zone abbreviation format in TZ files
• b26645f: 8339883: Open source several AWT/2D related tests
• 858b4f1: 8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior
• 59407fa: 8310525: DynamicLauncher for JDP test needs to try harder to find a free port
• 89759c8: 8321935: Define the term 'standard doclet'
• 65b9aba: 8339769: Incorrect error message during startup if working directory does not exist
• 1640bd2: 8340186: Shenandoah: Missing load_reference_barrier_phantom_narrow match in is_shenandoah_lrb_call
• ... and 22 more: https://git.openjdk.org/jdk/compare/4d011785717c34fa5a245735968c60142fc14af4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (49e6a6f7)

[tschatzl]

Thanks @stefank @walulyai for your reviews
/integrate

[openjdk]

Going to push as commit 7834662.
Since your change was applied there have been 34 commits pushed to the master branch:

• 10050a7: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch()
• 7849f25: 8340184: Bug in CompressedKlassPointers::is_in_encodable_range
• a4cf191: 8339793: Fix incorrect APX feature enabling with -XX:-UseAPX
• 3e03e66: 8340176: Replace usage of -noclassgc with -Xnoclassgc in test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.java
• 99d7185: 8340144: C1: remove unused Compilation::_max_spills
• 418bb42: 8340073: Support "%z" time zone abbreviation format in TZ files
• b26645f: 8339883: Open source several AWT/2D related tests
• 858b4f1: 8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior
• 59407fa: 8310525: DynamicLauncher for JDP test needs to try harder to find a free port
• 89759c8: 8321935: Define the term 'standard doclet'
• ... and 24 more: https://git.openjdk.org/jdk/compare/4d011785717c34fa5a245735968c60142fc14af4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 7834662.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.