8251549: Update docs on building for Git #21
Conversation
|
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
|
@jddarcy The following labels will be automatically applied to this pull request: |
jddarcy
changed the title
Webrevs
|
There was a problem hiding this comment.
Hi Joe, This looks OK. Are similar changes being made to http://openjdk.java.net/guide/producingChangeset.html as well given it refers to mercurial?
|
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1143 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Mailing list message from John Paul Adrian Glaubitz on build-dev: Hi Joe! On 9/5/20 10:21 PM, Joe Darcy wrote: Does that mean that OpenJDK development has officially moved to Github now? And are all OpenJDK members becoming members of the OpenJDK Github project? Thanks, -- |
|
Mailing list message from Joe Darcy on build-dev: Hello Adrian, On 9/5/2020 2:04 PM, John Paul Adrian Glaubitz wrote:
See the announcements about this transition, with instructions, on jdk-dev: https://mail.openjdk.java.net/pipermail/jdk-dev/2020-August/004588.html -Joe |
Co-authored-by: Magnus Ihse Bursie <mag@icus.se>
|
/integrate |
openjdk
bot
added
integrated
|
@jddarcy Since your change was applied there have been 1143 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 042734c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
openjdk#13 isn't a perfect revert of 0af22dc limited to SSLContextImpl.java and SunJSSE.java, since it doesn't remove the SharedSecrets import. This was already in this way in rh2020290-support_tls_1_3_in_fips.v1.patch, I'm now realizing this when doing the OpenJDK 11 backport and retrying the same approach in OpenJDK 17: ~~~ # Revert openjdk#13 git show 0bd5ca9 | git apply -R # Redo openjdk#13 by reverting 0af22dc in SSLContextImpl.java and SunJSSE.java git show 0af22dc | git apply -R --include=src/java.base/share/classes/sun/security/ssl/* ~~~ In openjdk#14, I forgot to delete the DHKF and DHKFLock static variables from FIPSKeyImporter, which are no longer used, see rh-openjdk#14 (comment). Reviewed-by: @gnu-andrew
openjdk#13 isn't a perfect revert of 0af22dc limited to SSLContextImpl.java and SunJSSE.java, since it doesn't remove the SharedSecrets import. This was already in this way in rh2020290-support_tls_1_3_in_fips.v1.patch, I'm now realizing this when doing the OpenJDK 11 backport and retrying the same approach in OpenJDK 17: ~~~ # Revert openjdk#13 git show 0bd5ca9 | git apply -R # Redo openjdk#13 by reverting 0af22dc in SSLContextImpl.java and SunJSSE.java git show 0af22dc | git apply -R --include=src/java.base/share/classes/sun/security/ssl/* ~~~ In openjdk#14, I forgot to delete the DHKF and DHKFLock static variables from FIPSKeyImporter, which are no longer used, see rh-openjdk#14 (comment). Reviewed-by: @gnu-andrew
* Even more review comments
* Re-write of atomic copy loops
* Change name of UnsafeCopyMemory{,Mark} to UnsafeMemory{Access,Mark}
* Only add a memory mark for byte unaligned fill
8251549: Update docs on building for Git
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/21/head:pull/21$ git checkout pull/21