Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times in calculation #210

Closed
wants to merge 1 commit into from

Conversation

walulyai
Copy link
Member

@walulyai walulyai commented Sep 16, 2020

Changed to consider only gc pause times within the long time interval.
Testing: Tier 1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times in calculation

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/210/head:pull/210
$ git checkout pull/210

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@walulyai The following label will be automatically applied to this pull request: hotspot-gc.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 16, 2020
@walulyai walulyai changed the title 8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times 8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times in calculation Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Ship it.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@walulyai This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times in calculation

Reviewed-by: tschatzl, kbarrett
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 9 commits pushed to the master branch:

  • 53a4ef2: 8202473: A type variable with multiple bounds does not correctly place type annotation
  • b87a159: 8252100: NumberOverflow in class MemoryCache
  • 9a7dcdc: 8253261: Disable CDS full module graph until JDK-8253081 is fixed
  • 1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 53a4ef267060b025dd632dc6e038d0dc6e16b25c.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2020
@walulyai
Copy link
Member Author

Lgtm. Ship it.

Thanks Thomas!

@mlbridge
Copy link

mlbridge bot commented Sep 17, 2020

Mailing list message from Kim Barrett on hotspot-gc-dev:

Looks good.

/reviewer add kimbarrett

@walulyai
Copy link
Member Author

Thanks Kim

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 17, 2020
@openjdk
Copy link

openjdk bot commented Sep 17, 2020

@walulyai
Your change (at version 8ff5b99) is now ready to be sponsored by a Committer.

@tschatzl
Copy link
Contributor

/sponsor

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Sep 17, 2020
@openjdk
Copy link

openjdk bot commented Sep 17, 2020

@tschatzl @walulyai Since your change was applied there have been 9 commits pushed to the master branch:

  • 53a4ef2: 8202473: A type variable with multiple bounds does not correctly place type annotation
  • b87a159: 8252100: NumberOverflow in class MemoryCache
  • 9a7dcdc: 8253261: Disable CDS full module graph until JDK-8253081 is fixed
  • 1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)

Your commit was automatically rebased without conflicts.

Pushed as commit 4ac6934.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants