Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339847: Broken link to the dieharder distribution website in SplittableRandom #21000

Closed
wants to merge 1 commit into from

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Sep 13, 2024

Could I get a review for this small change?
The page linked in SplittableRandom was moved at some point, this change points to the correct page to avoid redirects.

TIA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339847: Broken link to the dieharder distribution website in SplittableRandom (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21000/head:pull/21000
$ git checkout pull/21000

Update a local copy of the PR:
$ git checkout pull/21000
$ git pull https://git.openjdk.org/jdk.git pull/21000/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21000

View PR using the GUI difftool:
$ git pr show -t 21000

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21000.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2024

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339847: Broken link to the dieharder distribution website in SplittableRandom

Reviewed-by: iris, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @liach) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@nizarbenalla The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 13, 2024
@nizarbenalla nizarbenalla marked this pull request as ready for review September 13, 2024 15:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2024

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. New link appears to be correct.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2024
@nizarbenalla
Copy link
Member Author

I think this counts as "trivial" change and can be integrated without waiting for 24, if you agree Iris

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 13, 2024
@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@nizarbenalla
Your change (at version f7cead8) is now ready to be sponsored by a Committer.

@liach
Copy link
Member

liach commented Sep 13, 2024

Requesting @rgiulietti to sanity check before integration.

@rgiulietti
Copy link
Contributor

Looks good

@liach
Copy link
Member

liach commented Sep 13, 2024

Thanks Raffaello for the confirmation.

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

Going to push as commit 37bf589.
Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2024
@openjdk openjdk bot closed this Sep 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 13, 2024
@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@liach @nizarbenalla Pushed as commit 37bf589.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nizarbenalla nizarbenalla deleted the fix-dieharder-link branch September 19, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants