8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP #21001

nizarbenalla · 2024-09-13T15:01:23Z

Can I get a review for this doc-only change? I updated some links because the websites moved from HTTP to HTTPS. The redirects can cause some false-positives on tests.

TIA

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP (Sub-task - P4)

Reviewers

Phil Race (@prrace - Reviewer)
Harshitha Onkar (@honkar-jdk - Reviewer)
Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21001/head:pull/21001
$ git checkout pull/21001

Update a local copy of the PR:
$ git checkout pull/21001
$ git pull https://git.openjdk.org/jdk.git pull/21001/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21001

View PR using the GUI difftool:
$ git pr show -t 21001

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21001.diff

Webrev

Link to Webrev Comment

(C)

bridgekeeper · 2024-09-13T15:02:20Z

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-09-13T15:04:27Z

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP

Reviewed-by: prr, honkar, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

f0ae90f: 8340210: Add positionTestUI() to PassFailJFrame.Builder
eabfc6e: 8337563: NMT: rename MEMFLAGS to MemTag
d588182: 8338686: App classpath mismatch if a jar from the Class-Path attribute is on the classpath
5dc9723: 8340323: Test jdk/classfile/OptionsTest.java fails after JDK-8340200
90e92f9: 8339790: Support Intel APX setzucc instruction
28d009c: 8339934: Simplify Math.scalb(double) method
3e14fb9: 8340200: Misspelled constant AttributesProcessingOption.DROP_UNSTABLE_ATRIBUTES
64e3a9e: 8339574: Behavior of File.is{Directory,File,Hidden} is not documented with respect to symlinks
f877016: 8315273: (fs) Path.toRealPath(LinkOption.NOFOLLOW_LINKS) fails when "../../" follows a link (win)
b39e6a8: 8329816: Add SLEEF version 3.6.1
... and 71 more: https://git.openjdk.org/jdk/compare/0b3f2e64e83b589115989f9d14a6c644bc3008aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-09-13T15:05:14Z

@nizarbenalla The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-09-13T15:08:39Z

Webrevs

00: Full (06086104)

abdelhak-zaaim

The update to HTTPS is appreciated for consistency, though not strictly necessary since HTTP links already redirect to HTTPS. Please ensure all updated links function as expected and align with the project standards.

honkar-jdk · 2024-09-15T01:56:16Z

src/java.desktop/share/classes/java/awt/image/ColorConvertOp.java

@@ -690,7 +690,7 @@ private int getRenderingIntent (ICC_Profile profile) {
         * shall be set to zero. Thus, we are ignoring two most significant
         * bytes here.
         *
-         *  See http://www.color.org/ICC1v42_2006-05.pdf, section 7.2.15.
+         *  See https://www.color.org/ICC1v42_2006-05.pdf, section 7.2.15.


@prrace I wanted to clarify if the ICC Specification Doc links need to be updated to the latest one?
https://www.color.org/specification/ICC.1-2022-05.pdf

That would be out of scope for this.

honkar-jdk · 2024-09-15T01:57:40Z

src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java

@@ -1008,7 +1008,7 @@ public final class BaselineTIFFTagSet extends TIFFTagSet {
    /**
     * Constant specifying the "ICC Profile" tag.
     *
-     * @see <a href="http://www.color.org/ICC1V42.pdf">ICC Specification, section B.4: Embedding ICC profiles in TIFF files</a>
+     * @see <a href="https://www.color.org/ICC1V42.pdf">ICC Specification, section B.4: Embedding ICC profiles in TIFF files</a>


Same here ?

nizarbenalla · 2024-09-17T15:25:12Z

/integrate

openjdk · 2024-09-17T15:27:12Z

@nizarbenalla
Your change (at version 0608610) is now ready to be sponsored by a Committer.

aivanov-jdk · 2024-09-17T20:36:42Z

/sponsor

openjdk · 2024-09-17T20:37:48Z

@aivanov-jdk This change does not need sponsoring - the author is allowed to integrate it.

aivanov-jdk · 2024-09-17T20:40:25Z

@nizarbenalla Looks you're a committer now. You have to issue the /integrate command again.

nizarbenalla · 2024-09-18T11:07:29Z

I assumed this would be automatically merged once I became a committer.

Thank you all for the reviews!

/integrate

openjdk · 2024-09-18T11:08:15Z

Going to push as commit 45e438f.
Since your change was applied there have been 88 commits pushed to the master branch:

4ff17c1: 8319873: Add windows implementation for jcmd System.map and System.dump_map
3895b8f: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
5381f55: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences()
d23c59e: 8340280: Avoid calling MT.invokerType() when creating LambdaForms
147e300: 8340015: Open source several AWT focus tests - series 7
202fd42: 8340213: jcmd VM.events ignores max argument
dfc9093: 8340132: Remove internal CpException for reading malformed utf8
f0ae90f: 8340210: Add positionTestUI() to PassFailJFrame.Builder
eabfc6e: 8337563: NMT: rename MEMFLAGS to MemTag
d588182: 8338686: App classpath mismatch if a jar from the Class-Path attribute is on the classpath
... and 78 more: https://git.openjdk.org/jdk/compare/0b3f2e64e83b589115989f9d14a6c644bc3008aa...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-09-18T11:08:22Z

@nizarbenalla Pushed as commit 45e438f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

aivanov-jdk · 2024-09-18T12:30:11Z

I assumed this would be automatically merged once I became a committer.

No, the Skara bots don't revisit the PRs after the OpenJDK Census is changed.

You weren't a committer when you issued the /integrate command, so it required a sponsor. By the time I decided to sponsor, you're already a committer, and no one can sponsor integrating any more.

nizarbenalla added 2 commits September 13, 2024 15:43

Update color.org and wapforum.org links to use HTTPS instead of HTTP

ef0ccfc

Update color.org and wapforum.org links to use HTTPS instead of HTTP

0608610

(C)

nizarbenalla marked this pull request as ready for review September 13, 2024 15:04

openjdk bot added the rfr Pull request is ready for review label Sep 13, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Sep 13, 2024

prrace approved these changes Sep 13, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2024

abdelhak-zaaim reviewed Sep 14, 2024

View reviewed changes

honkar-jdk reviewed Sep 15, 2024

View reviewed changes

honkar-jdk approved these changes Sep 16, 2024

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 17, 2024

aivanov-jdk approved these changes Sep 17, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Sep 18, 2024

openjdk bot closed this Sep 18, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 18, 2024

nizarbenalla deleted the fix-colororg-links branch September 18, 2024 21:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP #21001

8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP #21001

nizarbenalla commented Sep 13, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 13, 2024

openjdk bot commented Sep 13, 2024 •

edited

Loading

openjdk bot commented Sep 13, 2024

mlbridge bot commented Sep 13, 2024

abdelhak-zaaim left a comment •

edited by bridgekeeper bot

Loading

honkar-jdk Sep 15, 2024 •

edited

Loading

prrace Sep 16, 2024

honkar-jdk Sep 15, 2024

nizarbenalla commented Sep 17, 2024

openjdk bot commented Sep 17, 2024

aivanov-jdk commented Sep 17, 2024

openjdk bot commented Sep 17, 2024

aivanov-jdk commented Sep 17, 2024

nizarbenalla commented Sep 18, 2024

openjdk bot commented Sep 18, 2024

openjdk bot commented Sep 18, 2024

aivanov-jdk commented Sep 18, 2024

8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP #21001

8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP #21001

Conversation

nizarbenalla commented Sep 13, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Sep 13, 2024

openjdk bot commented Sep 13, 2024 • edited Loading

openjdk bot commented Sep 13, 2024

mlbridge bot commented Sep 13, 2024

Webrevs

abdelhak-zaaim left a comment • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

honkar-jdk Sep 15, 2024 • edited Loading

Choose a reason for hiding this comment

prrace Sep 16, 2024

Choose a reason for hiding this comment

honkar-jdk Sep 15, 2024

Choose a reason for hiding this comment

nizarbenalla commented Sep 17, 2024

openjdk bot commented Sep 17, 2024

aivanov-jdk commented Sep 17, 2024

openjdk bot commented Sep 17, 2024

aivanov-jdk commented Sep 17, 2024

nizarbenalla commented Sep 18, 2024

openjdk bot commented Sep 18, 2024

openjdk bot commented Sep 18, 2024

aivanov-jdk commented Sep 18, 2024

nizarbenalla commented Sep 13, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Sep 13, 2024 •

edited

Loading

abdelhak-zaaim left a comment •

edited by bridgekeeper bot

Loading

honkar-jdk Sep 15, 2024 •

edited

Loading