Skip to content

Conversation

@D-D-H
Copy link
Contributor

@D-D-H D-D-H commented Sep 15, 2024

Hi,

Please review this trivial change that removed the unused field Compilation::_max_spills.

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340144: C1: remove unused Compilation::_max_spills (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21007/head:pull/21007
$ git checkout pull/21007

Update a local copy of the PR:
$ git checkout pull/21007
$ git pull https://git.openjdk.org/jdk.git pull/21007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21007

View PR using the GUI difftool:
$ git pr show -t 21007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21007.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2024

👋 Welcome back ddong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 15, 2024

@D-D-H This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340144: C1: remove unused Compilation::_max_spills

Reviewed-by: thartmann, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • e1ebeef: 8340131: Refactor internal makeHiddenClassDefiner to take option mask instead of Set
  • 05b9d47: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file
  • 5459518: 8339627: Cleanup Unsafe.setMemory intrinsic code
  • a4eb9a0: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher
  • 6be15c3: 8340012: [C2] assert(KlassEncodingMetaspaceMax > pd) failed: change encoding max if new encoding after 8338526
  • 4b79063: 8339842: Open source several AWT focus tests - series 2
  • dc00eb8: 8338912: CDS: Segmented roots array
  • 74add0e: 8340105: Expose BitMap::print_on in release builds
  • 0e0f10f: 8340102: Move assert-only loop in OopMapSort::sort under debug macro
  • a0794e0: 8339639: Opensource few AWT PopupMenu tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2024
@openjdk
Copy link

openjdk bot commented Sep 15, 2024

@D-D-H The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 15, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2024

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2024
@D-D-H
Copy link
Contributor Author

D-D-H commented Sep 17, 2024

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 17, 2024

Going to push as commit 99d7185.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 418bb42: 8340073: Support "%z" time zone abbreviation format in TZ files
  • b26645f: 8339883: Open source several AWT/2D related tests
  • 858b4f1: 8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior
  • 59407fa: 8310525: DynamicLauncher for JDP test needs to try harder to find a free port
  • 89759c8: 8321935: Define the term 'standard doclet'
  • 65b9aba: 8339769: Incorrect error message during startup if working directory does not exist
  • 1640bd2: 8340186: Shenandoah: Missing load_reference_barrier_phantom_narrow match in is_shenandoah_lrb_call
  • 996790c: 8339954: Print JVMCI names with the Compiler.{perfmap,codelist,CodeHeap_Analytics} diagnostic commands
  • e1ebeef: 8340131: Refactor internal makeHiddenClassDefiner to take option mask instead of Set
  • 05b9d47: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file
  • ... and 8 more: https://git.openjdk.org/jdk/compare/a8f143c6abe7669c232cabda3a4e8df726de036e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 17, 2024
@openjdk openjdk bot closed this Sep 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 17, 2024
@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@D-D-H Pushed as commit 99d7185.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants