8340176: Replace usage of -noclassgc with -Xnoclassgc in test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.java

[jaikiran]

Can I please get a review of this test-only change which replaces the usage of -noclassgc with -Xnoclassgc option when launching the test?

As noted in https://bugs.openjdk.org/browse/JDK-8340176, the -noclassgc is an undocumented option of the java launcher, which it converts to -Xnoclassgc before passing it to the JVM. Instead of that option, the documented -Xnoclassgc should be used.

No new test has been introduced and the modified test continues to pass after this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340176: Replace usage of -noclassgc with -Xnoclassgc in test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.java (Bug - P4)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21012/head:pull/21012
$ git checkout pull/21012

Update a local copy of the PR:
$ git checkout pull/21012
$ git pull https://git.openjdk.org/jdk.git pull/21012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21012

View PR using the GUI difftool:
$ git pr show -t 21012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21012.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340176: Replace usage of -noclassgc with -Xnoclassgc in test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.java

Reviewed-by: kevinw, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 996790c: 8339954: Print JVMCI names with the Compiler.{perfmap,codelist,CodeHeap_Analytics} diagnostic commands
• e1ebeef: 8340131: Refactor internal makeHiddenClassDefiner to take option mask instead of Set
• 05b9d47: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file
• 5459518: 8339627: Cleanup Unsafe.setMemory intrinsic code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b48eb870)

[kevinjwalls]

Looks good, thanks 8-)

[jaikiran]

Thank you Kevin and Leonid for the reviews.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 3e03e66.
Since your change was applied there have been 12 commits pushed to the master branch:

• 99d7185: 8340144: C1: remove unused Compilation::_max_spills
• 418bb42: 8340073: Support "%z" time zone abbreviation format in TZ files
• b26645f: 8339883: Open source several AWT/2D related tests
• 858b4f1: 8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior
• 59407fa: 8310525: DynamicLauncher for JDP test needs to try harder to find a free port
• 89759c8: 8321935: Define the term 'standard doclet'
• 65b9aba: 8339769: Incorrect error message during startup if working directory does not exist
• 1640bd2: 8340186: Shenandoah: Missing load_reference_barrier_phantom_narrow match in is_shenandoah_lrb_call
• 996790c: 8339954: Print JVMCI names with the Compiler.{perfmap,codelist,CodeHeap_Analytics} diagnostic commands
• e1ebeef: 8340131: Refactor internal makeHiddenClassDefiner to take option mask instead of Set
• ... and 2 more: https://git.openjdk.org/jdk/compare/a4eb9a063fb9e4a87923d464fe2c50ed5466acff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 3e03e66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.