8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image #21022

slowhog · 2024-09-16T17:50:52Z

This PR split out large array/set construction into separate factory methods to avoid oversized method trying to construct several of those.

In order to do that, we will need to generate those help methods on demand in the class builder. Here we have two approach, one is for dedup set, which is processed in advance so we can know what methods should be created.

Another is for random set, such as packages, thus we put those request into a queue to amend the class later.

To keep the optimization of caching built value that are references more than once, it was implemented using local vars, which doesn't work well for helper methods. The existing approach to populate local vars doesn't work well with larger scope of split operation, as the slot was allocated on lazily built, but the transfer is captured in advance, this count could mismatch as built time and run time.

So we make this build in advance, and use a static array for values referred more than once.

All the codegen instead of giving index to be loaded, the builder snippet now load the wanted set/array to the operand stack to be consistent.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image (Bug - P3)

Reviewers

Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21022/head:pull/21022
$ git checkout pull/21022

Update a local copy of the PR:
$ git checkout pull/21022
$ git pull https://git.openjdk.org/jdk.git pull/21022/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21022

View PR using the GUI difftool:
$ git pr show -t 21022

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21022.diff

Using Webrev

Link to Webrev Comment

…nge while creating a jlink image

bridgekeeper · 2024-09-16T17:51:49Z

👋 Welcome back henryjen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-09-16T17:51:59Z

@slowhog This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

0a5ef82: 8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException
ea49537: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller
2e00816: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025
88fa3b2: 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off
6ee2bd2: 8347147: [REDO] AccessFlags can be u2 in metadata
a641932: 8346310: Duplicate !HAS_PENDING_EXCEPTION check in DynamicArchive::dump_at_exit
49ee4df: 8166983: Remove old/legacy unused tzdata files
3fe0818: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
55bcf4c: 8346047: JFR: Incorrect percentile value in 'jfr view'
ae3fc46: 8345580: Remove const from Node::_idx which is modified
... and 81 more: https://git.openjdk.org/jdk/compare/4d77dbad4e15c5392878e7bc91cd8eb7ce49a482...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-09-16T17:52:43Z

@slowhog The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-09-16T17:55:24Z

Webrevs

AlanBateman · 2024-09-22T15:38:19Z

It would be helpful for potential reviewers if the PR description included a brief summary on the changes to the code generated, otherwise it's a lot to wade through to understand the changes.

slowhog · 2024-09-23T03:15:45Z

Absolutely, updated the description.

test/jdk/tools/jlink/JLink3500Packages.java

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

test/jdk/tools/jlink/JLink3500Packages.java

mlchung

Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

mlchung · 2024-10-02T00:20:32Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

-            void visitElement(T element, CodeBuilder cob) {
-                cob.loadConstant((ConstantDesc)element);
-            }
+            class SetReference<T extends Comparable<T>> implements Comparable<SetReference<T>> {


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Added, please let me know any suggestions or questions.

Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

…tant pool size

slowhog · 2024-10-29T17:35:49Z

The latest changes have snippets for paginating array, and can build set on top of that. Tests on the snippets should ensure the pagination code working properly.
The ModuleDescriptorBuilder is brought into a separate file, ModuleInfoLoader, which can be used to generate bytecode to load a ModuleDesceriptor element onto the operand stack.
Then we use the paginated array to ensure construction of arrays/set will be paginated properly given we setup the generated helper method properly in the class.

This change should eliminate limitation on generated code size due to large array or set and shift the limitation factor to be the constant pool size.

jerboaa

Typo

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

… reference

slowhog · 2024-11-15T07:02:27Z

Introduce general Snippet interface to emit bytecodes.
ElementLoader -> CollectionElementBuilder, which build a Snippet to load the element at index.
With that, snippets are built early for all elements, makes the setup easier to follow.

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ModuleDescriptorBuilder.java

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

mlchung · 2024-12-13T23:24:33Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

+        final ClassDesc classDesc;
+        Snippet[] loadElementSnippets;
+
+        public ArraySnippetBuilder(ClassDesc elementType) {


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

I am planning to provides default value for those and validation when build.
Same applies to classBuilder, as it's optional and depending on whether helper methods is needed.
Additional constructors would be nice to have, as we can add for types and perhaps a tested page size.

mlchung

Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung

Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T21:51:22Z

test/jdk/tools/jlink/JLink20000Packages.java

+
+        JImageGenerator.getJLinkTask()
+                .modulePath(out)
+                .output(src.resolve("out-jlink"))


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T21:52:57Z

test/jdk/tools/jlink/SnippetsTest.java

+ * @run junit SnippetsTest
+ */
+public class SnippetsTest {
+    private static final boolean WRITE_CLASS_FILE = Boolean.parseBoolean(System.getProperty("DumpArraySnippetsTestClasses", "true"));


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T22:12:54Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

+         * Set referenced more than once will be read from the cache, cacheSetupSnippet contains
+         * the bytecode to populate that cache.
+         */
+        static record DedupSet(Map<Set<String>, Snippet> stringSets,


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T22:13:32Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

-             * Retrieve the index to the given set of Strings. Emit code to
-             * generate it when SetBuilder::build is called.
+             * Generate bytecode to load a set onto the operand stack.
+             * Use cache if the set is references more than once.


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T22:18:36Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

-            void visitElement(T element, CodeBuilder cob) {
-                cob.loadConstant((ConstantDesc)element);
-            }
+            class SetReference<T extends Comparable<T>> implements Comparable<SetReference<T>> {


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T22:29:45Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

+        public static final int DEFAULT_PAGE_SIZE = 2000;
+
+        /**
+         * Arbitary default values based on 15K code size on ~30 bytes per element


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T22:30:10Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

+    }
+
+    /**
+     * Describe a operand that can be load onto the operand stack.


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T22:32:00Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

+         * Enable pagination if the count of elements is larger than pageSize or DEFAULT_THRESHOLD
+         */
+        public CollectionSnippetBuilder enablePagination(String methodNamePrefix, int pageSize) {
+            return enablePagination(methodNamePrefix, pageSize, Math.min(pageSize, DEFAULT_THRESHOLD));


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

I think about this, and it depends on how you look at the API.

The idea is that those three parameters are essential to enable pagination from disabled state. A default value is used when user is to enable pagination not specifying an explicit value, so a clear default is adapted rather than lingering with current setting.

Otherwise, user can use property methods to change page size or threshold.

I like the idea of use methodNamePrefix as the enable/disable check. However, trying to explain the value of page size and threshold is current value, which would be default value without setting before is a little bit more complex, more so if trying to explain choosing the smaller value of page size and default threshold where we honestly have no idea if user have set a specific value or not.

I switched default to disable in the latest commit. And if it helps, I can remove those two enablePagination methods using default values.

mlchung · 2024-12-20T22:34:17Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

+            this.activatePagingThreshold = -1;
+            this.methodNamePrefix = null;


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2024-12-20T22:37:21Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

+                        if (hasNextPage) {
+                            cob.invokestatic(
+                                    ownerClassDesc,
+                                    methodNamePrefix + (pageNo + 1),


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung

Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2025-01-03T01:33:46Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

+     *      ar[1] = elements[1];
+     *      ...
+     *      ar[pageSize-1] = elements[pageSize - 1];
+     *      methodNamePrefix1(ar);


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2025-01-03T01:34:36Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java

+            }
+        }
+
+        // each helper function is T[] methodNamePrefix{pageNo}(T[])


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2025-01-03T01:43:34Z

test/jdk/tools/jlink/JLink20000Packages.java

+        javac(new String[]{
+                "-d", out,
+                "--module-source-path", src.toString(),
+                "--module", "bug8321413x"
+        });


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mlchung · 2025-01-03T01:44:00Z

test/jdk/tools/jlink/SnippetsTest.java

@@ -0,0 +1,271 @@
+/*
+ * Copyright (c) 2024, 2024, Oracle and/or its affiliates. All rights reserved.


Hi @mlchung, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mlchung" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

slowhog · 2025-01-08T18:00:22Z

@AlanBateman Do I need another approval before integrate this? If so, would you have a look?
@jerboaa , @liach Thanks for reviewing, is there anything else you would like to add?

jerboaa · 2025-01-08T20:10:35Z

@jerboaa , @liach Thanks for reviewing, is there anything else you would like to add?

Good from my point of view. The only comment I have is to check the warning in #21022 (comment) and possibly change the fix version to JDK 25 before integrating.

liach · 2025-01-08T21:29:37Z

I think the usages of ClassFile API looks good in the last review. And for the skara warning, you can simply clear the fix versions in the JBS issue.

slowhog · 2025-01-09T17:34:43Z

/integrate

openjdk · 2025-01-09T17:36:23Z

Going to push as commit 22f70a7.
Since your change was applied there have been 113 commits pushed to the master branch:

3bfa952: 8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements
1ef77cd: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory
72f1114: 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters
cb9a98b: 8347141: Several javac tests compile with an unnecessary -Xlint:-path flag
f9b1133: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
9c72ded: 8346036: Unnecessary Hashtable usage in javax.swing.text.html.parser.Entity
3024a73: 8345782: Refining the cases that libjsig deprecation warning is issued
2801bc6: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE
ceae2b9: 8347121: Add missing @serial tags to module java.base
8c87ea2: 8346478: RISC-V: Refactor add/sub assembler routines
... and 103 more: https://git.openjdk.org/jdk/compare/4d77dbad4e15c5392878e7bc91cd8eb7ce49a482...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-01-09T17:36:31Z

@slowhog Pushed as commit 22f70a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8321413: IllegalArgumentException: Code length outside the allowed ra…

db79e46

…nge while creating a jlink image

openjdk bot changed the title ~~8321413: IllegalArgumentException: Code length outside the allowed ra…~~ 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image Sep 16, 2024

openjdk bot added the rfr Pull request is ready for review label Sep 16, 2024

openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 16, 2024

liach reviewed Sep 26, 2024

View reviewed changes

slowhog added 2 commits September 26, 2024 18:14

Address review comments

ffce5eb

Missing from last commit

858703e

mlchung reviewed Oct 3, 2024

View reviewed changes

slowhog added 6 commits October 4, 2024 10:39

Fix typo and add comments based on review feedback

b279401

Add more comments, move snippet generation code into standalone class

ab6459d

Loadable support with paging support. The limiting factor is now cons…

1e552d0

…tant pool size

Merge remote-tracking branch 'openjdk/master' into JDK-8321413

2d40e05

Separate out ModuleDescriptorBuilder and use LoadableArray for paging

94a927f

Fix regression failed to setup helper methods properly

0ba821a

jerboaa reviewed Oct 29, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java Outdated Show resolved Hide resolved

slowhog added 2 commits October 29, 2024 15:38

Fix typo and comment to match latest implementation

9107699

Rename based on feedback to emphasis building a snippet for loading a…

69d8466

… reference

slowhog added 2 commits November 15, 2024 09:32

Minor cleanup

784fd41

Merge remote-tracking branch 'openjdk/master' into JDK-8321413

4e82d04

liach reviewed Dec 11, 2024

View reviewed changes

Move up Snippet setup as a builder

9dbea04

mlchung reviewed Dec 13, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java Outdated Show resolved Hide resolved

mlchung reviewed Dec 13, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java Outdated Show resolved Hide resolved

mlchung reviewed Dec 13, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java Outdated Show resolved Hide resolved

mlchung reviewed Dec 13, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java Outdated Show resolved Hide resolved

mlchung reviewed Dec 13, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java Outdated Show resolved Hide resolved

mlchung reviewed Dec 13, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java Outdated Show resolved Hide resolved

mlchung reviewed Dec 13, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ModuleDescriptorBuilder.java Outdated Show resolved Hide resolved

mlchung reviewed Dec 13, 2024

View reviewed changes

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java Outdated Show resolved Hide resolved

mlchung reviewed Dec 13, 2024

View reviewed changes

slowhog added 2 commits December 19, 2024 00:29

Javadoc and some minor refactoring

4833be8

Merge remote-tracking branch 'openjdk/master' into JDK-8321413

d5a9329

mlchung reviewed Dec 20, 2024

View reviewed changes

Address review comments

8fc4e2f

mlchung approved these changes Jan 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2025

Clean up

760f667

openjdk bot removed the ready Pull request is ready to be integrated label Jan 3, 2025

mlchung approved these changes Jan 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2025

openjdk bot added the integrated Pull request has been integrated label Jan 9, 2025

openjdk bot closed this Jan 9, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2025

slowhog deleted the JDK-8321413 branch January 16, 2025 00:39

		this.activatePagingThreshold = -1;
		this.methodNamePrefix = null;

		@@ -0,0 +1,271 @@
		/*
		* Copyright (c) 2024, 2024, Oracle and/or its affiliates. All rights reserved.

8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image #21022

8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image #21022

Conversation

slowhog commented Sep 16, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 16, 2024

openjdk bot commented Sep 16, 2024 • edited Loading

openjdk bot commented Sep 16, 2024

mlbridge bot commented Sep 16, 2024 • edited Loading

Webrevs

AlanBateman commented Sep 22, 2024

slowhog commented Sep 23, 2024

mlchung left a comment • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Oct 2, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

slowhog Oct 4, 2024

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

slowhog commented Oct 29, 2024

jerboaa left a comment

Choose a reason for hiding this comment

slowhog commented Nov 15, 2024

mlchung Dec 13, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

slowhog Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

mlchung left a comment • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung left a comment • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

slowhog Dec 23, 2024

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Dec 20, 2024 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung left a comment • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Jan 3, 2025 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Jan 3, 2025 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Jan 3, 2025 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

mlchung Jan 3, 2025 • edited by bridgekeeper bot Loading

Choose a reason for hiding this comment

slowhog commented Jan 8, 2025

jerboaa commented Jan 8, 2025

liach commented Jan 8, 2025

slowhog commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

slowhog commented Sep 16, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Sep 16, 2024 •

edited

Loading

mlbridge bot commented Sep 16, 2024 •

edited

Loading

mlchung left a comment •

edited by bridgekeeper bot

Loading

mlchung Oct 2, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 13, 2024 •

edited by bridgekeeper bot

Loading

slowhog Dec 13, 2024 •

edited

Loading

mlchung left a comment •

edited by bridgekeeper bot

Loading

mlchung left a comment •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung Dec 20, 2024 •

edited by bridgekeeper bot

Loading

mlchung left a comment •

edited by bridgekeeper bot

Loading

mlchung Jan 3, 2025 •

edited by bridgekeeper bot

Loading

mlchung Jan 3, 2025 •

edited by bridgekeeper bot

Loading

mlchung Jan 3, 2025 •

edited by bridgekeeper bot

Loading

mlchung Jan 3, 2025 •

edited by bridgekeeper bot

Loading