8286851: Deprecate for removal several of the undocumented java launcher options

[jaikiran]

Can I please get a review of this change which proposes to deprecate several outdated and undocumented java launcher options? This addresses https://bugs.openjdk.org/browse/JDK-8286851.

Specifically, the non-standard launcher options -verbosegc, -noclassgc, -verify, -verifyremote, -ss, -ms and -mx will be deprecated for removal. With this change, a deprecation warning will be printed, if any of these options are used.

No new tests have been added for this change. Existing tests in tier1, tier2 and tier3 continue to pass.

I'll create a CSR shortly for this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8340244 to be approved

Issues

• JDK-8286851: Deprecate for removal several of the undocumented java launcher options (Bug - P4)
• JDK-8340244: Deprecate for removal several of the undocumented java launcher options (CSR)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21031/head:pull/21031
$ git checkout pull/21031

Update a local copy of the PR:
$ git checkout pull/21031
$ git pull https://git.openjdk.org/jdk.git pull/21031/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21031

View PR using the GUI difftool:
$ git pr show -t 21031

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21031.diff

Webrev

Link to Webrev Comment

[jaikiran]

/csr needed

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286851: Deprecate for removal several of the undocumented java launcher options

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 202fd42: 8340213: jcmd VM.events ignores max argument
• dfc9093: 8340132: Remove internal CpException for reading malformed utf8
• f0ae90f: 8340210: Add positionTestUI() to PassFailJFrame.Builder
• eabfc6e: 8337563: NMT: rename MEMFLAGS to MemTag
• d588182: 8338686: App classpath mismatch if a jar from the Class-Path attribute is on the classpath
• 5dc9723: 8340323: Test jdk/classfile/OptionsTest.java fails after JDK-8340200
• 90e92f9: 8339790: Support Intel APX setzucc instruction
• 28d009c: 8339934: Simplify Math.scalb(double) method
• 3e14fb9: 8340200: Misspelled constant AttributesProcessingOption.DROP_UNSTABLE_ATRIBUTES
• 64e3a9e: 8339574: Behavior of File.is{Directory,File,Hidden} is not documented with respect to symlinks
• ... and 8 more: https://git.openjdk.org/jdk/compare/7849f252937dc774a1935cc4c68f2a46649f180b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@jaikiran please create a CSR request for issue JDK-8286851 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8d1adf57)

[dholmes-ora]

LGTM!

Thanks

[jaikiran]

A CSR is now ready for review for this change https://bugs.openjdk.org/browse/JDK-8340244

[jaikiran]

Thank you David for the review here and on the CSR.

I've run our CI tests all the way through tier8 to make sure that this additional deprecation logging doesn't cause unexpected failures in tests (there was one test which needed to be fixed and that has now been integrated too). I'll go ahead with the integration of this PR now.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 6719899.
Since your change was applied there have been 37 commits pushed to the master branch:

• ac58b61: 8339416: [s390x] Provide implementation for resolve_global_jobject
• 537447f: 8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java
• d9c6744: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test
• 88a1c05: 8340078: Open source several 2D tests
• 3184912: 8339962: Open source AWT TextField tests - Set1
• 9cfc03a: 8340391: Windows jcmd System.map and System.dump_map tests failing
• 6ff287a: 8340233: Missed ThreadWXEnable in jfrNativeLibraryLoadEvent.cpp
• ae39a66: 8339992: RISC-V: some minor improvements of base64_vector_decode_round
• 471a51a: 8340368: windows-x64-slowdebug build fails after JDK-8319873
• 08a2f84: 8339738: RISC-V: Vectorize crc32 intrinsic
• ... and 27 more: https://git.openjdk.org/jdk/compare/7849f252937dc774a1935cc4c68f2a46649f180b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 6719899.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.