Skip to content

8340273: Remove CounterHalfLifeTime #21034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dlunde
Copy link
Member

@dlunde dlunde commented Sep 17, 2024

Issue Summary

The CounterHalfLifeTime flag is no longer used and should be removed.

Changeset

Remove CounterHalfLifeTime.

Testing

N/A


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340273: Remove CounterHalfLifeTime (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21034/head:pull/21034
$ git checkout pull/21034

Update a local copy of the PR:
$ git checkout pull/21034
$ git pull https://git.openjdk.org/jdk.git pull/21034/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21034

View PR using the GUI difftool:
$ git pr show -t 21034

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21034.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2024

👋 Welcome back dlunden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@dlunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340273: Remove CounterHalfLifeTime

Reviewed-by: chagedorn, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • c6721a0: 8340009: Improve the output from assert_different_registers
  • 7834662: 8340119: Remove oopDesc::size_might_change()
  • 10050a7: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch()
  • 7849f25: 8340184: Bug in CompressedKlassPointers::is_in_encodable_range
  • a4cf191: 8339793: Fix incorrect APX feature enabling with -XX:-UseAPX
  • 3e03e66: 8340176: Replace usage of -noclassgc with -Xnoclassgc in test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.java
  • 99d7185: 8340144: C1: remove unused Compilation::_max_spills
  • 418bb42: 8340073: Support "%z" time zone abbreviation format in TZ files
  • b26645f: 8339883: Open source several AWT/2D related tests
  • 858b4f1: 8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior
  • ... and 42 more: https://git.openjdk.org/jdk/compare/3c40afa59c93860150960d478a9d2ffe33d4ce32...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8340273 8340273: Remove CounterHalfLifeTime Sep 17, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 17, 2024
@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@dlunde The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 17, 2024
@dlunde
Copy link
Member Author

dlunde commented Sep 17, 2024

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 17, 2024
@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@dlunde
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 17, 2024

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 17, 2024
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@dlunde
Copy link
Member Author

dlunde commented Sep 17, 2024

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 17, 2024

Going to push as commit 8b6e277.
Since your change was applied there have been 52 commits pushed to the master branch:

  • c6721a0: 8340009: Improve the output from assert_different_registers
  • 7834662: 8340119: Remove oopDesc::size_might_change()
  • 10050a7: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch()
  • 7849f25: 8340184: Bug in CompressedKlassPointers::is_in_encodable_range
  • a4cf191: 8339793: Fix incorrect APX feature enabling with -XX:-UseAPX
  • 3e03e66: 8340176: Replace usage of -noclassgc with -Xnoclassgc in test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.java
  • 99d7185: 8340144: C1: remove unused Compilation::_max_spills
  • 418bb42: 8340073: Support "%z" time zone abbreviation format in TZ files
  • b26645f: 8339883: Open source several AWT/2D related tests
  • 858b4f1: 8339960: GenShen: Fix inconsistencies in generational Shenandoah behavior
  • ... and 42 more: https://git.openjdk.org/jdk/compare/3c40afa59c93860150960d478a9d2ffe33d4ce32...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 17, 2024
@openjdk openjdk bot closed this Sep 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 17, 2024
@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@dlunde Pushed as commit 8b6e277.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants