8340306: Add border around instructions in PassFailJFrame

[aivanov-jdk]

A trivial change which adds border around instruction text. It makes the text easier to read.

(In some tests, people added leading spaces to each line to make the instructions easier to read; with the added border, there's no need for this trick.)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340306: Add border around instructions in PassFailJFrame (Enhancement - P4)

Reviewers

• Harshitha Onkar (@honkar-jdk - Reviewer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21038/head:pull/21038
$ git checkout pull/21038

Update a local copy of the PR:
$ git checkout pull/21038
$ git pull https://git.openjdk.org/jdk.git pull/21038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21038

View PR using the GUI difftool:
$ git pr show -t 21038

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21038.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340306: Add border around instructions in PassFailJFrame

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 6ff287a: 8340233: Missed ThreadWXEnable in jfrNativeLibraryLoadEvent.cpp
• ae39a66: 8339992: RISC-V: some minor improvements of base64_vector_decode_round
• 471a51a: 8340368: windows-x64-slowdebug build fails after JDK-8319873
• 08a2f84: 8339738: RISC-V: Vectorize crc32 intrinsic
• 1d070a3: 8337302: Undefined type variable results in null
• aeba1ea: 8340272: C2 SuperWord: JMH benchmark for Reduction vectorization
• 19b2cee: 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view)
• 45e438f: 8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP
• 4ff17c1: 8319873: Add windows implementation for jcmd System.map and System.dump_map
• 3895b8f: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
• ... and 16 more: https://git.openjdk.org/jdk/compare/269cd38b55391364db0f92291eb29c3b6803db94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (15c4c92d)

[aivanov-jdk]

Updated look:

The text is no longer attaches to the left of the frame.

Previous look:

[lawrence-andrew]

@aivanov-jdk thanks for adding . Now the test instruction looks highlighted.
LGTM

[honkar-jdk]

LGTM, test instructions are better indented now and not close to the edge.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit 0120d3e.
Since your change was applied there have been 37 commits pushed to the master branch:

• 2faf8b8: 8340007: Refactor KeyEvent/FunctionKeyTest.java
• 8908812: 8337674: ZGC: Consistent style for naming private static constants
• 118c9ad: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java
• c58fbef: 8340276: Test java/lang/management/ThreadMXBean/Locks.java failed with NullPointerException
• 6719899: 8286851: Deprecate for removal several of the undocumented java launcher options
• ac58b61: 8339416: [s390x] Provide implementation for resolve_global_jobject
• 537447f: 8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java
• d9c6744: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test
• 88a1c05: 8340078: Open source several 2D tests
• 3184912: 8339962: Open source AWT TextField tests - Set1
• ... and 27 more: https://git.openjdk.org/jdk/compare/269cd38b55391364db0f92291eb29c3b6803db94...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit 0120d3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.