8259849: Shenandoah: Rename store-val to IU-barrier

[rkennke]

We named the IU barriers StoreValEnqueueBarrier and various similar variations of this. Instead of naming it after how it's implemented, we should name it after its purpose: support IU-marking. It also looks confusing to have enqueue_barrier() and similar stuff, where no barrier is actually enqueued.

The renaming was 100% mechanical.

Testing:

• hotspot_gc_shenandoah (x86_64, x86_32, aarch64)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259849: Shenandoah: Rename store-val to IU-barrier

Reviewers

• Zhengyu Gu (@zhengyu123 - Reviewer) ⚠️ Review applies to 2d2b013
• Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to 3804e64

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2104/head:pull/2104
$ git checkout pull/2104

[bridgekeeper]

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rkennke The following labels will be automatically applied to this pull request:

• hotspot
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (3181002)
• 01: Full - Incremental (3804e64)
• 00: Full (2d2b013)

[zhengyu123]

Some file's copyright year need to be updated. Otherwise, looks good.

[openjdk]

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259849: Shenandoah: Rename store-val to IU-barrier

Reviewed-by: zgu, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• db9c114: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
• 61292be: 8259681: Remove the Marlin rendering engine (single-precision)
• ff275b3: 8259403: Zero: crash with NULL MethodHandle receiver
• e93f08e: 8074101: Add verification that all tasks are actually claimed during roots processing
• 917f7e9: 8259650: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"
• 3f19ef6: 8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails
• 68cf65d: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1
• 5dc5d94: 8256110: Create implementation for NSAccessibilityStepper protocol
• 5f2e280: 8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13
• da4cf05: 8258755: jpackage: Invalid 32-bit exe when building app-image
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/5855d52a2a670a49b7a968fd58404b5d1836a8e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

This makes sense.

[shipilev]

...except that GHA report these two tests have failed:
gc/shenandoah/options/TestWrongBarrierDisable.java
gc/shenandoah/options/TestWrongBarrierEnable.java

[rkennke]

...except that GHA report these two tests have failed:
gc/shenandoah/options/TestWrongBarrierDisable.java
gc/shenandoah/options/TestWrongBarrierEnable.java

Right. Those should be fixed now. Only remaining GHA failure is Windows:

configure: error: Could not find a C compiler.

Do you know what's up there?

[shipilev]

Right. Those should be fixed now. Only remaining GHA failure is Windows:

configure: error: Could not find a C compiler.
Do you know what's up there?

Known issue: https://bugs.openjdk.java.net/browse/JDK-8259679

[rkennke]

/integrate

[openjdk]

@rkennke Since your change was applied there have been 22 commits pushed to the master branch:

• db9c114: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
• 61292be: 8259681: Remove the Marlin rendering engine (single-precision)
• ff275b3: 8259403: Zero: crash with NULL MethodHandle receiver
• e93f08e: 8074101: Add verification that all tasks are actually claimed during roots processing
• 917f7e9: 8259650: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"
• 3f19ef6: 8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails
• 68cf65d: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1
• 5dc5d94: 8256110: Create implementation for NSAccessibilityStepper protocol
• 5f2e280: 8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13
• da4cf05: 8258755: jpackage: Invalid 32-bit exe when building app-image
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/5855d52a2a670a49b7a968fd58404b5d1836a8e1...master

Your commit was automatically rebased without conflicts.

Pushed as commit e60c992.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.