Skip to content

Conversation

@serhiysachkov
Copy link
Contributor

@serhiysachkov serhiysachkov commented Sep 18, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21055/head:pull/21055
$ git checkout pull/21055

Update a local copy of the PR:
$ git checkout pull/21055
$ git pull https://git.openjdk.org/jdk.git pull/21055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21055

View PR using the GUI difftool:
$ git pr show -t 21055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21055.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2024

👋 Welcome back serhiysachkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 18, 2024

@serhiysachkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java

Reviewed-by: dfuchs, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • c58fbef: 8340276: Test java/lang/management/ThreadMXBean/Locks.java failed with NullPointerException
  • 6719899: 8286851: Deprecate for removal several of the undocumented java launcher options
  • ac58b61: 8339416: [s390x] Provide implementation for resolve_global_jobject
  • 537447f: 8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java
  • d9c6744: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test
  • 88a1c05: 8340078: Open source several 2D tests
  • 3184912: 8339962: Open source AWT TextField tests - Set1
  • 9cfc03a: 8340391: Windows jcmd System.map and System.dump_map tests failing
  • 6ff287a: 8340233: Missed ThreadWXEnable in jfrNativeLibraryLoadEvent.cpp
  • ae39a66: 8339992: RISC-V: some minor improvements of base64_vector_decode_round
  • ... and 6 more: https://git.openjdk.org/jdk/compare/4ff17c14a572a59b60d728c3626f430932eecea6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Sep 18, 2024

@serhiysachkov The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added net net-dev@openjdk.org rfr Pull request is ready for review labels Sep 18, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2024

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial and looks reasonable.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2024
@serhiysachkov
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 18, 2024
@openjdk
Copy link

openjdk bot commented Sep 18, 2024

@serhiysachkov
Your change (at version 453749c) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

Going to push as commit 118c9ad.
Since your change was applied there have been 16 commits pushed to the master branch:

  • c58fbef: 8340276: Test java/lang/management/ThreadMXBean/Locks.java failed with NullPointerException
  • 6719899: 8286851: Deprecate for removal several of the undocumented java launcher options
  • ac58b61: 8339416: [s390x] Provide implementation for resolve_global_jobject
  • 537447f: 8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java
  • d9c6744: 8340360: Update -mx to -Xmx in UnninstallUIMemoryLeaks test
  • 88a1c05: 8340078: Open source several 2D tests
  • 3184912: 8339962: Open source AWT TextField tests - Set1
  • 9cfc03a: 8340391: Windows jcmd System.map and System.dump_map tests failing
  • 6ff287a: 8340233: Missed ThreadWXEnable in jfrNativeLibraryLoadEvent.cpp
  • ae39a66: 8339992: RISC-V: some minor improvements of base64_vector_decode_round
  • ... and 6 more: https://git.openjdk.org/jdk/compare/4ff17c14a572a59b60d728c3626f430932eecea6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2024
@openjdk openjdk bot closed this Sep 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 19, 2024
@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@shipilev @serhiysachkov Pushed as commit 118c9ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net net-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants