8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options

[prkoppul]

Updated the code to call buildTrustedCerts only when the -trustcacerts option is specified

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options (Bug - P4)

Reviewers

• Sean Coffey (@coffeys - Reviewer)
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21058/head:pull/21058
$ git checkout pull/21058

Update a local copy of the PR:
$ git checkout pull/21058
$ git pull https://git.openjdk.org/jdk.git pull/21058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21058

View PR using the GUI difftool:
$ git pr show -t 21058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21058.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back pkoppula! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prkoppul This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options

Reviewed-by: coffeys, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 7579d37: 8338995: New Object to ObjectMonitor mapping: PPC64 implementation
• cecb0b3: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java
• 0120d3e: 8340306: Add border around instructions in PassFailJFrame
• 2faf8b8: 8340007: Refactor KeyEvent/FunctionKeyTest.java
• 8908812: 8337674: ZGC: Consistent style for naming private static constants
• 118c9ad: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java
• c58fbef: 8340276: Test java/lang/management/ThreadMXBean/Locks.java failed with NullPointerException
• 6719899: 8286851: Deprecate for removal several of the undocumented java launcher options
• ac58b61: 8339416: [s390x] Provide implementation for resolve_global_jobject
• 537447f: 8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java
• ... and 16 more: https://git.openjdk.org/jdk/compare/147e30070d8adbe65453a3a9316b9324890ea25f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@prkoppul The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[coffeys]

looks reasonable to me

[mlbridge]

Webrevs

• 00: Full (1c0fb434)

[prkoppul]

/integrate

[openjdk]

@prkoppul
Your change (at version 1c0fb43) is now ready to be sponsored by a Committer.

[coffeys]

/sponsor

[openjdk]

Going to push as commit c9bee17.
Since your change was applied there have been 26 commits pushed to the master branch:

• 7579d37: 8338995: New Object to ObjectMonitor mapping: PPC64 implementation
• cecb0b3: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java
• 0120d3e: 8340306: Add border around instructions in PassFailJFrame
• 2faf8b8: 8340007: Refactor KeyEvent/FunctionKeyTest.java
• 8908812: 8337674: ZGC: Consistent style for naming private static constants
• 118c9ad: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java
• c58fbef: 8340276: Test java/lang/management/ThreadMXBean/Locks.java failed with NullPointerException
• 6719899: 8286851: Deprecate for removal several of the undocumented java launcher options
• ac58b61: 8339416: [s390x] Provide implementation for resolve_global_jobject
• 537447f: 8339980: [s390x] ProblemList jdk/java/util/zip/CloseInflaterDeflaterTest.java
• ... and 16 more: https://git.openjdk.org/jdk/compare/147e30070d8adbe65453a3a9316b9324890ea25f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coffeys @prkoppul Pushed as commit c9bee17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.