8340368: windows-x64-slowdebug build fails after JDK-8319873

[stefank]

The build fails with:

 * For target hotspot_variant-server_libjvm_objs_static_memMapPrinter_windows.obj:
 memMapPrinter_windows.cpp
 src\hotspot\os\windows\memMapPrinter_windows.cpp(126): error C2504: 'os::win32': base class undefined
 src\hotspot\os\windows\memMapPrinter_windows.cpp(130): error C2027: use of undefined type 'os::win32'
 src\hotspot\share\runtime/os.hpp(1015): note: see declaration of 'os::win32'
 src\hotspot\os\windows\memMapPrinter_windows.cpp(130): error C3861: 'print_windows_version': identifier not found
 src\hotspot\os\windows\memMapPrinter_windows.cpp(131): error C2027: use of undefined type 'os::win32'
 src\hotspot\share\runtime/os.hpp(1015): note: see declaration of 'os::win32'
 src\hotspot\os\windows\memMapPrinter_windows.cpp(131): error C3861: 'print_uptime_info': identifier not found
 src\hotspot\os\windows\memMapPrinter_windows.cpp(132): error C2653: 'VM_Version': is not a class or namespace name
 src\hotspot\os\windows\memMapPrinter_windows.cpp(132): error C3861: 'print_platform_virtualization_info': identifier not found 

when you build without precompiled headers.

I've added the missing includes for the things listed above and ran it through our CI build system.

My intention is to push this ASAP to un-break the builds.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340368: windows-x64-slowdebug build fails after JDK-8319873 (Bug - P1)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Kevin Walls (@kevinjwalls - Reviewer)
• Axel Boldt-Christmas (@xmas92 - Reviewer)
• Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21063/head:pull/21063
$ git checkout pull/21063

Update a local copy of the PR:
$ git checkout pull/21063
$ git pull https://git.openjdk.org/jdk.git pull/21063/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21063

View PR using the GUI difftool:
$ git pr show -t 21063

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21063.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[jaikiran]

I don't have knowledge of this area, but this change looks reasonable and helps the build job failures to be addressed.

[openjdk]

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340368: windows-x64-slowdebug build fails after JDK-8319873

Reviewed-by: jpai, kevinw, aboldtch, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 08a2f84: 8339738: RISC-V: Vectorize crc32 intrinsic
• 1d070a3: 8337302: Undefined type variable results in null
• aeba1ea: 8340272: C2 SuperWord: JMH benchmark for Reduction vectorization

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@stefank The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7e13f1c5)

[kevinjwalls]

Looks sensible, thanks for finding this quickly 8-)

[fisk]

Looks good.

[stefank]

Thanks for the reviews!
/integrate

[openjdk]

Going to push as commit 471a51a.
Since your change was applied there have been 3 commits pushed to the master branch:

• 08a2f84: 8339738: RISC-V: Vectorize crc32 intrinsic
• 1d070a3: 8337302: Undefined type variable results in null
• aeba1ea: 8340272: C2 SuperWord: JMH benchmark for Reduction vectorization

Your commit was automatically rebased without conflicts.

[openjdk]

@stefank Pushed as commit 471a51a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.