Skip to content

8259859: Missing metaspace NMT memory tag #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jan 16, 2021

Please review this trivial fix that added missing NMT memory tag for metaspace.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2107/head:pull/2107
$ git checkout pull/2107

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 16, 2021
@openjdk
Copy link

openjdk bot commented Jan 16, 2021

@zhengyu123 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 16, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 16, 2021

Webrevs

@zhengyu123
Copy link
Contributor Author

Friendly ping!

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and trivial.

@openjdk
Copy link

openjdk bot commented Jan 19, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259859: Missing metaspace NMT memory tag

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • 33dcc00: 8132984: incorrect type for Reference.discovered
  • 3edf393: 8259978: PPC64 builds broken after JDK-8258004
  • 5d8861b: 8259995: Missing comma to separate years in copyright header
  • 5cfb36e: 8259036: Failed JfrVersionSystem invariant when VM built with -fno-elide-constructors
  • c0e9c44: 8259962: Shenandoah: task queue statistics is inconsistent after JDK-8255019
  • 82adfb3: 8134540: Much nearly duplicated code for PerfMemory support
  • a9519c8: 8259924: GitHub actions fail on Linux x86_32 with "Could not configure libc6:i386"
  • 139f5d3: 8259035: Comments for load order of hsdis should be updated
  • bd81ccf: 8259957: Build failure without C1 Compiler after JDK-8258004
  • dfee7b8: 8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)"
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/0ec2c969dfa83d36496e18fbc803f227ab6471aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 19, 2021
@zhengyu123
Copy link
Contributor Author

/integrate

@zhengyu123
Copy link
Contributor Author

Thanks, Ioi

@openjdk openjdk bot closed this Jan 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2021
@openjdk
Copy link

openjdk bot commented Jan 19, 2021

@zhengyu123 Since your change was applied there have been 49 commits pushed to the master branch:

  • 33dcc00: 8132984: incorrect type for Reference.discovered
  • 3edf393: 8259978: PPC64 builds broken after JDK-8258004
  • 5d8861b: 8259995: Missing comma to separate years in copyright header
  • 5cfb36e: 8259036: Failed JfrVersionSystem invariant when VM built with -fno-elide-constructors
  • c0e9c44: 8259962: Shenandoah: task queue statistics is inconsistent after JDK-8255019
  • 82adfb3: 8134540: Much nearly duplicated code for PerfMemory support
  • a9519c8: 8259924: GitHub actions fail on Linux x86_32 with "Could not configure libc6:i386"
  • 139f5d3: 8259035: Comments for load order of hsdis should be updated
  • bd81ccf: 8259957: Build failure without C1 Compiler after JDK-8258004
  • dfee7b8: 8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)"
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/0ec2c969dfa83d36496e18fbc803f227ab6471aa...master

Your commit was automatically rebased without conflicts.

Pushed as commit a37cd5a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe
Copy link
Member

tstuefe commented Jan 20, 2021

Too late, but looks good, thanks for fixing!

@zhengyu123 zhengyu123 deleted the JDK-8259859-missing-metaspace-tag branch May 2, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants