Skip to content

8340228: Open source couple more miscellaneous AWT tests#21097

Closed
azuev-java wants to merge 1 commit intoopenjdk:masterfrom
azuev-java:JDK-8340228
Closed

8340228: Open source couple more miscellaneous AWT tests#21097
azuev-java wants to merge 1 commit intoopenjdk:masterfrom
azuev-java:JDK-8340228

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Sep 19, 2024

Cleaning up and opensourcing three more tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340228: Open source couple more miscellaneous AWT tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21097/head:pull/21097
$ git checkout pull/21097

Update a local copy of the PR:
$ git checkout pull/21097
$ git pull https://git.openjdk.org/jdk.git pull/21097/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21097

View PR using the GUI difftool:
$ git pr show -t 21097

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21097.diff

Webrev

Link to Webrev Comment

Cleaning up and opensourcing three more tests.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2024

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340228: Open source couple more miscellaneous AWT tests

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 185 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2024
@openjdk
Copy link

openjdk bot commented Sep 19, 2024

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 19, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2024
@azuev-java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 25, 2024

Going to push as commit f7bc9ba.
Since your change was applied there have been 228 commits pushed to the master branch:

  • 0e0b0b0: 8340684: Reading from an input stream backed by a closed ZipFile has no test coverage
  • 81b5f09: 8340946: Add vmTestbase/gc/memory/Nio/Nio.java and java/nio/Buffer/LimitDirectMemory.java to problem list
  • 0474f02: 8340815: Add SECURITY.md file
  • fb70325: 8338583: NMT: Malloc overhead is calculated incorrectly
  • 083b980: 8340568: Incorrect escaping of single quotes when pretty-printing character literals
  • d8790aa: 8340885: Desugar ZipCoder.Comparison
  • 120463d: 8339541: CSS rule is not specific enough
  • 1b9898a: 8340843: [PPC64/s390x] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694
  • 9806d21: 8340808: RISC-V: Client build fails after JDK-8339738
  • 97a3933: 8339771: RISC-V: Reduce icache flushes
  • ... and 218 more: https://git.openjdk.org/jdk/compare/56387a09810a3204ed820885e0ff0b26408be59d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2024
@openjdk openjdk bot closed this Sep 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2024
@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@azuev-java Pushed as commit f7bc9ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants