8234808: jdb quoted option parsing broken #211
Migrating this review from the mailing list into a pull request. Some background: when jdb launches debuggee process it passes java options from "options" value for CommandLineLaunch connector and forward options specified before command. The fix solves several discovered issues: - proper handling of java options with spaces - if both way are used to specify java options, forwarded options override options from "options" value VMConnection class implements tricky logic for "options" field parsing for JFR needs (handling of single and double quotes). I decided to keep it as is to avoid massive test failures with JFR (there is no test coverage for this functionality and I'm not sure I understand all requirements).
@alexmenkov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the
Your changes look good, but I don't fully understand your comment about the JFR needs. I do see your special test case:
So I assume you are talking about special handling for the above example, but is this really special handling of JFR optins, or just special handling of options that contain suboptions.
This is handling of the options with suboptions, but researching old changes for this (for JFR needs) I didn't get full understanding what are the requirements. Unfortunately there was no test introduced for the functionality, so I poke command line examples from several old issues.
Is there a bug you can reference in this PR in case someone stumbles across this in the future? Or better yet link them to the CR for this PR.
After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 137 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
➡️ To integrate this PR with the above commit message to the
@alexmenkov Since your change was applied there have been 137 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit d1f9b8a.
💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.