Skip to content

8340540: Problemlist DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java #21109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Sep 20, 2024

Quick problemlisting. Thank you.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340540: Problemlist DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21109/head:pull/21109
$ git checkout pull/21109

Update a local copy of the PR:
$ git checkout pull/21109
$ git pull https://git.openjdk.org/jdk.git pull/21109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21109

View PR using the GUI difftool:
$ git pr show -t 21109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21109.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340540: Problemlist DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java

Reviewed-by: kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@tstuefe To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@tstuefe
Copy link
Member Author

tstuefe commented Sep 20, 2024

Ping @kevinjwalls

@kevinjwalls
Copy link
Contributor

Thanks. Are you OK to create a subtask of 8340401 for this problemlisting, so we keep 8340401 for the real follow on fix.
8340401 appears in the problem list entry, that's good.

@tstuefe tstuefe changed the title JDK-8340401: Problemlist DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java JDK-8340540: Problemlist DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java Sep 20, 2024
@tstuefe
Copy link
Member Author

tstuefe commented Sep 20, 2024

Thanks. Are you OK to create a subtask of 8340401 for this problemlisting, so we keep 8340401 for the real follow on fix. 8340401 appears in the problem list entry, that's good.

Good catch. I thought that's what I did, but got confused mid flight. This should be right.

@openjdk openjdk bot changed the title JDK-8340540: Problemlist DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java 8340540: Problemlist DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java Sep 20, 2024
Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all good for a trivial problemlisting.
We'll be back here again soon probably!

@tstuefe
Copy link
Member Author

tstuefe commented Sep 20, 2024

Thanks @kevinjwalls !

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

Going to push as commit ae63aaa.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2024
@openjdk openjdk bot closed this Sep 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@tstuefe Pushed as commit ae63aaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants