Skip to content

8340411: open source several 2D imaging tests #21113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Sep 20, 2024

open source several 2d imaging related tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8340411: open source several 2D imaging tests

Issue

  • JDK-8340411: open source several 2D imaging tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21113/head:pull/21113
$ git checkout pull/21113

Update a local copy of the PR:
$ git checkout pull/21113
$ git pull https://git.openjdk.org/jdk.git pull/21113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21113

View PR using the GUI difftool:
$ git pr show -t 21113

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21113.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340411: open source several 2D imaging tests

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

  • 64275e6: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems
  • 5cffddc: 8338471: Assert deleted methods not returned by CallInfo
  • 40fba14: 8340232: Optimize DataInputStream::readUTF
  • ab81197: 8339198: Remove tag field from AbstractPoolEntry
  • 90d3a64: 8340537: Typo in javadoc of java.util.jar.JarFile
  • e087ede: 8340269: [s390x] TestLargeStub.java failure after 8338123
  • 9bcde4f: 8338658: New Object to ObjectMonitor mapping: s390x implementation
  • ae63aaa: 8340540: Problemlist DcmdMBeanPermissionsTest.java and SystemDumpMapTest.java
  • fe80618: 8339972: Make a few fields in SortingFocusTraversalPolicy static
  • 3c22d83: 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout
  • ... and 54 more: https://git.openjdk.org/jdk/compare/5dc9723c8172e288872f744bac5fd2342475767a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8340411 8340411: open source several 2D imaging tests Sep 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 20, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 20, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 20, 2024
@prrace
Copy link
Contributor Author

prrace commented Sep 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

Going to push as commit 8dcf7b8.
Since your change was applied there have been 82 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 23, 2024
@openjdk openjdk bot closed this Sep 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@prrace Pushed as commit 8dcf7b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants