Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13 #2112

Closed
wants to merge 1 commit into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 17, 2021

This is a workaround to a bug in fgetxattr(2) on macOS 10.13.6 with APFS where it doesn't return -1/ERANGE when the buffer is too small. This bug leads to UserDefinedFileAttributeView/Basic.java failing on macOS 10.13 systems, the test is passing on 10.14 and 10.15. The change just means that FileStore.supportsFileAttributeView will return false when asked if it supports UserDefinedFileAttributeView.class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2112/head:pull/2112
$ git checkout pull/2112

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2021

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 17, 2021

@AlanBateman The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jan 17, 2021
@AlanBateman AlanBateman marked this pull request as ready for review January 17, 2021 08:28
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up!

Do you have any idea when fgetxattr() was fixed in 10.14? For example,
if it was fixed in 10.14.4, then it would be necessary to include a micro
version in the check. We may not care about that level of precision if
we presume that folks are running the version that we tested (10.14.6).

@openjdk
Copy link

openjdk bot commented Jan 17, 2021

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • da4cf05: 8258755: jpackage: Invalid 32-bit exe when building app-image
  • c3bdbf9: 8259238: Clean up Log.java and remove usage of non-final static variables.
  • 6d6a23e: 8259062: Remove MacAppStoreBundler

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 17, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2021

Mailing list message from Sebastian Stenzel on nio-dev:

Maybe someone with access to Radar (Apple's bug tracker) can answer this. This is the only public information I found so far: https://openradar.appspot.com/44533931 <https://openradar.appspot.com/44533931>, which marks this as a duplicate of ticket 39173408.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20210117/bf69a208/attachment.htm>

@AlanBateman
Copy link
Contributor Author

Do you have any idea when fgetxattr() was fixed in 10.14? For example,
if it was fixed in 10.14.4, then it would be necessary to include a micro
version in the check. We may not care about that level of precision if
we presume that folks are running the version that we tested (10.14.6).

The 10.14.* systems that I could find are all up to date with 10.14.6. You may be right that it was fixed in an update but I don't think we have any way to find out. It's a real shame that Apple don't have a public issue tracker. So let's go with the current fix for now. I assume 10.13 will be EOL soon, in which case we can stop the os.version check. Thanks for the review.

@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jan 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2021
@openjdk
Copy link

openjdk bot commented Jan 17, 2021

@AlanBateman Since your change was applied there have been 3 commits pushed to the master branch:

  • da4cf05: 8258755: jpackage: Invalid 32-bit exe when building app-image
  • c3bdbf9: 8259238: Clean up Log.java and remove usage of non-final static variables.
  • 6d6a23e: 8259062: Remove MacAppStoreBundler

Your commit was automatically rebased without conflicts.

Pushed as commit 5f2e280.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants