8340596: Remove dead code from RequiresSetenv function in java.base/unix/native/libjli/java_md.c

[jaikiran]

Can I please get a review of this trivial change which removes dead code from the RequiresSetenv() function?

As noted in https://bugs.openjdk.org/browse/JDK-8340596 this appears to be a left-over from the changes in https://bugs.openjdk.org/browse/JDK-8244224.

No new tests have been added and existing tier1, tier2 and tier3 tests continue to pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340596: Remove dead code from RequiresSetenv function in java.base/unix/native/libjli/java_md.c (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21125/head:pull/21125
$ git checkout pull/21125

Update a local copy of the PR:
$ git checkout pull/21125
$ git pull https://git.openjdk.org/jdk.git pull/21125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21125

View PR using the GUI difftool:
$ git pr show -t 21125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21125.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340596: Remove dead code from RequiresSetenv function in java.base/unix/native/libjli/java_md.c

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• dd49879: 8340524: Remove NarrowPtrStruct

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cb1133d8)

[dholmes-ora]

Looks good and trivial.

Thanks

[jaikiran]

Thank you David for the review.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 865d99f.
Since your change was applied there have been 21 commits pushed to the master branch:

• 3411f9d: 8339995: Open source several AWT focus tests - series 6
• 40cde00: 8340114: Remove outdated SelectVersion() function from the launcher and update the code comments explaining the code flow
• c8ae848: 8340707: ProblemList applications/ctw/modules/java_base.java due to JDK-8340683
• cd796e0: 8338918: Remove non translated file name from WinResources resource bundle
• e97f0fe: 8340365: Position the first window of a window list
• 8dcf7b8: 8340411: open source several 2D imaging tests
• 833ff29: 8340461: Amend description for logArea
• c6f1d5f: 8319332: Security properties files inclusion
• 0f9f777: 8336025: Improve ZipOutputSream validation of MAX CEN Header field limits
• ea8f35b: 8340183: Shenandoah: Incorrect match for clone barrier in is_gc_barrier_node
• ... and 11 more: https://git.openjdk.org/jdk/compare/ab06a878f888827026424530781f0af414a8a611...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 865d99f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.