Skip to content

8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages #21127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Sep 23, 2024

TestAllocateHeapAt.java expects that creating the heap file works in the current director (.). But when using persistent hugepages (-XX:+UseLargePages) this would require the filesystem to be a HugeTLBFS.

I propose that we do not allow running these tests with persistent hugepages.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21127/head:pull/21127
$ git checkout pull/21127

Update a local copy of the PR:
$ git checkout pull/21127
$ git pull https://git.openjdk.org/jdk.git pull/21127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21127

View PR using the GUI difftool:
$ git pr show -t 21127

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21127.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2024

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages

Reviewed-by: tschatzl, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@xmas92 The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 23, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2024

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2024
@xmas92
Copy link
Member Author

xmas92 commented Sep 24, 2024

Thanks for the reviews.
/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

Going to push as commit 4098acc.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 6c91a16: 8340367: Opensource few AWT image tests
  • 865d99f: 8340596: Remove dead code from RequiresSetenv function in java.base/unix/native/libjli/java_md.c
  • 3411f9d: 8339995: Open source several AWT focus tests - series 6
  • 40cde00: 8340114: Remove outdated SelectVersion() function from the launcher and update the code comments explaining the code flow
  • c8ae848: 8340707: ProblemList applications/ctw/modules/java_base.java due to JDK-8340683
  • cd796e0: 8338918: Remove non translated file name from WinResources resource bundle
  • e97f0fe: 8340365: Position the first window of a window list
  • 8dcf7b8: 8340411: open source several 2D imaging tests
  • 833ff29: 8340461: Amend description for logArea
  • c6f1d5f: 8319332: Security properties files inclusion
  • ... and 51 more: https://git.openjdk.org/jdk/compare/2faf8b8d582183275b1fdc92313a1c63c1753e80...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2024
@openjdk openjdk bot closed this Sep 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@xmas92 Pushed as commit 4098acc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants