8340419: ZGC: Create an UseLargePages adaptation of TestAllocateHeapAt.java

[xmas92]

JDK-8340146 / #21127 disables TestAllocateHeapAt.java when running with persistent hugepages because it makes assumptions on the underlying file systems.

I propose creating a version of this tests which instead first checks if there is an appropriate mount point for a persistent hugepages heap file, and only runs the test if exists.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340419: ZGC: Create an UseLargePages adaptation of TestAllocateHeapAt.java (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)
• Joel Sikström (@jsikstro - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21128/head:pull/21128
$ git checkout pull/21128

Update a local copy of the PR:
$ git checkout pull/21128
$ git pull https://git.openjdk.org/jdk.git pull/21128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21128

View PR using the GUI difftool:
$ git pr show -t 21128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21128.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340419: ZGC: Create an UseLargePages adaptation of TestAllocateHeapAt.java

Reviewed-by: stefank, sjohanss, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 142 new commits pushed to the master branch:

• ae4d2f1: 8340621: Open source several AWT List tests
• dd56990: 8340639: Open source few more AWT List tests
• ade17ec: 8340560: Open Source several AWT/2D font and rendering tests
• 73ebb84: 8340721: Clarify special case handling of unboxedType and getWildcardType
• ed140f5: 8341101: [ARM32] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694
• 082125d: 8340404: CharsetProvider specification updates
• a7bfced: 8337679: Memset warning in src/hotspot/share/adlc/adlArena.cpp
• f554c3f: 8341059: Change Entrust TLS distrust date to November 12, 2024
• 65200a9: 8340490: Shenandoah: Optimize ShenandoahPacer
• 824a297: 8341057: Add 2 SSL.com TLS roots
• ... and 132 more: https://git.openjdk.org/jdk/compare/2faf8b8d582183275b1fdc92313a1c63c1753e80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c5c05848)

[kstefanj]

Looks good.

[kstefanj]

Any reason to include -XX:+ZGenerational or should we just skip it?

[xmas92]

I try to keep this option explicit in tests until it is removed. Avoid assumptions about default values.

[jsikstro]

I think this looks good.

[xmas92]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit 6514aef.
Since your change was applied there have been 142 commits pushed to the master branch:

• ae4d2f1: 8340621: Open source several AWT List tests
• dd56990: 8340639: Open source few more AWT List tests
• ade17ec: 8340560: Open Source several AWT/2D font and rendering tests
• 73ebb84: 8340721: Clarify special case handling of unboxedType and getWildcardType
• ed140f5: 8341101: [ARM32] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694
• 082125d: 8340404: CharsetProvider specification updates
• a7bfced: 8337679: Memset warning in src/hotspot/share/adlc/adlArena.cpp
• f554c3f: 8341059: Change Entrust TLS distrust date to November 12, 2024
• 65200a9: 8340490: Shenandoah: Optimize ShenandoahPacer
• 824a297: 8341057: Add 2 SSL.com TLS roots
• ... and 132 more: https://git.openjdk.org/jdk/compare/2faf8b8d582183275b1fdc92313a1c63c1753e80...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit 6514aef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.