-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages #21129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into |
@xmas92 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 280 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@xmas92 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for the reviews. |
Going to push as commit f2b10c6.
Your commit was automatically rebased without conflicts. |
Similarly to JDK-8340146 / #21127 does not work well with transparent hugepages.
Because a machine may be configured in such a way that UseTransperetHugePages option gets ignored, the test driver must also check if it will be. As such I extracted the
test/hotspot/jtreg/runtime/os/HugePageConfiguration.java
utility into shared test library.On none linux machines the
vm.opt.final.UseTransparentHugePages
will be null, but the test checksos.family == "linux"
first. I have not observed an issue with the JTREG filter on none linux machines. But will double check that it does not cause an issue.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21129/head:pull/21129
$ git checkout pull/21129
Update a local copy of the PR:
$ git checkout pull/21129
$ git pull https://git.openjdk.org/jdk.git pull/21129/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21129
View PR using the GUI difftool:
$ git pr show -t 21129
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21129.diff
Using Webrev
Link to Webrev Comment