Skip to content

8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages #21129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Sep 23, 2024

Similarly to JDK-8340146 / #21127 does not work well with transparent hugepages.

Because a machine may be configured in such a way that UseTransperetHugePages option gets ignored, the test driver must also check if it will be. As such I extracted the test/hotspot/jtreg/runtime/os/HugePageConfiguration.java utility into shared test library.

On none linux machines the vm.opt.final.UseTransparentHugePages will be null, but the test checks os.family == "linux" first. I have not observed an issue with the JTREG filter on none linux machines. But will double check that it does not cause an issue.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21129/head:pull/21129
$ git checkout pull/21129

Update a local copy of the PR:
$ git checkout pull/21129
$ git pull https://git.openjdk.org/jdk.git pull/21129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21129

View PR using the GUI difftool:
$ git pr show -t 21129

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21129.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2024

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages

Reviewed-by: stefank, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 280 new commits pushed to the master branch:

  • 9d60300: 8344199: Incorrect excluded field value set by getEventWriter intrinsic
  • 8bd080b: 8341901: Using 'var' keyword switch pattern matching causes compiler error
  • 76a55c3: 8341334: CDS: Parallel relocation
  • 499186b: 8343902: javax/swing/plaf/nimbus/8041642/bug8041642.java fails in ubuntu22.04
  • b12c5b4: 8344218: Remove calls to SecurityManager and and doPrivileged in java.net.NetworkInterface after JEP 486 integration
  • d85dd77: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules
  • 9e92a9e: 8344059: Remove doPrivileged calls from windows platform sources in the java.desktop module
  • 3729884: 8344371: RISC-V: compiler/intrinsics/chacha/TestChaCha20.java fails after JDK-8343555
  • dd86369: 8344262: Win32AttachOperationRequest objects are created by using global new
  • 5cb0d43: 8293040: Argfile documentation for java launcher tool is confusing regarding usage of wildcards
  • ... and 270 more: https://git.openjdk.org/jdk/compare/646d64e88003ef2a2e1960cef0cc59d1a97bb912...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@xmas92 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 23, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 24, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 24, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2024

@xmas92 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 4, 2024
Copy link
Member

@jsikstro jsikstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 19, 2024
@xmas92
Copy link
Member Author

xmas92 commented Nov 21, 2024

Thanks for the reviews.
/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

Going to push as commit f2b10c6.
Since your change was applied there have been 347 commits pushed to the master branch:

  • 5ccd510: 8326369: Add test to verify bimorphic inlining happens after morphism changes
  • 93aa7e2: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate()
  • 10def48: 8344236: Revisit SecurityManager usage in jdk.net after JEP 486 integration
  • 7105bb9: 8344664: Remove some un-used java/sun.security imports in the java.desktop module
  • a01aa22: 8342281: Deprecate for removal javax.sound.sampled.AudioPermission
  • 4fbf272: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize
  • 1343911: 8340334: Update jcmd VM.events max parameter to be INT
  • 400eb9b: 8344524: Remove SecurityManager related code from jdk.jlink module
  • a599c30: 8344471: Remove SecurityManager related code from java.compiler module
  • b9bf447: 8344057: Remove doPrivileged calls from unix platform sources in the java.desktop module
  • ... and 337 more: https://git.openjdk.org/jdk/compare/646d64e88003ef2a2e1960cef0cc59d1a97bb912...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2024
@openjdk openjdk bot closed this Nov 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@xmas92 Pushed as commit f2b10c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants