Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)" #2113

Closed
wants to merge 2 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Jan 17, 2021

This test failed on the system where the wrong resolution was used(too small). Looks like that resolution was set by one of the tests and was not reset back because of a misconfigured automatic system reboot. I have checked that the initial version of the test works fine on our "clean" systems. But would like to tweak the test anyway just in case.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2113/head:pull/2113
$ git checkout pull/2113

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 17, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@@ -388,7 +388,7 @@ public static void main(String[] args) throws Exception
MenuBar mb = new MenuBar();
mb.add(new Menu("Hello"));
frame.setMenuBar(mb);
frame.setBounds(400, 180, 1068, 821);
frame.setBounds(400, 180, 300, 300);
Copy link
Member Author

@mrserb mrserb Jan 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a small resolution(800x600) or similar is used, then the window manager moves this big window to the left/top but the test is expected the specific x/y coordinate.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 17, 2021

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the awt label Jan 17, 2021
@mrserb mrserb marked this pull request as ready for review Jan 17, 2021
@openjdk openjdk bot added the rfr label Jan 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 17, 2021

Webrevs

Loading

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Jan 18, 2021

Hi Sergey,

I am trying to verify the fix in my mac, if i simply run the test without any change it is throwing error : "Use -nativepath to specify the location of native code".
Do we need to change anything in the mac preferences to run this test?

Thanks,
Jay

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 18, 2021

I am trying to verify the fix in my mac, if i simply run the test without any change it is throwing error : "Use -nativepath to specify the location of native code".
Do we need to change anything in the mac preferences to run this test?

This test has a native part so you need to specify this option and point it to the built test bundle, or you can run it via make file:
make test TEST="jtreg:open/test/jdk/java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java"

Loading

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Jan 18, 2021

Thanks for the clarification.
I was able to reproduce the issue and change certainly solves the issue when i start the jtreg test from default display (Without external display launching test from retina/ With external display as default and launching jtreg test from external display). But when i run jtreg test from retina and keep external display as default, test still fails with same behaviour as seen without this fix.

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 18, 2021

The problem in the multiscreen environment was caused by using the wrong NScreen to calculate the "y" coordinate. The "NSScreen mainScreen" returns the "Returns the screen object containing the window with the keyboard focus" actually the window where the terminal is located, not the screeen(0,0) expected by the test.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)"

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • db9c114: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
  • 61292be: 8259681: Remove the Marlin rendering engine (single-precision)
  • ff275b3: 8259403: Zero: crash with NULL MethodHandle receiver
  • e93f08e: 8074101: Add verification that all tasks are actually claimed during roots processing
  • 917f7e9: 8259650: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"
  • 3f19ef6: 8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails
  • 68cf65d: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1
  • 5dc5d94: 8256110: Create implementation for NSAccessibilityStepper protocol
  • 5f2e280: 8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13
  • da4cf05: 8258755: jpackage: Invalid 32-bit exe when building app-image
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/90c73d057d6bd26031727b73886d6eaa6b153ca0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 18, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 19, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 19, 2021
@mrserb mrserb deleted the JDK-8259511 branch Jan 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 19, 2021

@mrserb Since your change was applied there have been 24 commits pushed to the master branch:

  • 14ce8f1: 8259870: zBarrier.inline.hpp should not include javaClasses.hpp
  • a1a851b: Merge
  • bb0821e: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
  • cd25bf2: 8259574: SIGSEGV in BFSClosure::closure_impl
  • d5ca3b3: 8259641: C2: assert(early->dominates(LCA)) failed: early is high enough
  • 492bebc: 8258004: Remove unnecessary inclusion of vm_version.hpp
  • 533a2d3: 8258961: move some fields of SafePointNode from public to protected
  • 6b4732f: 8259679: GitHub actions should use MSVC 14.28
  • 061ffc4: 8249245: assert(((((JfrTraceIdBits::load(klass)) & ((JfrTraceIdEpoch::this_epoch_method_and_class_bits()))) != 0))) failed: invariant
  • e60c992: 8259849: Shenandoah: Rename store-val to IU-barrier
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/90c73d057d6bd26031727b73886d6eaa6b153ca0...master

Your commit was automatically rebased without conflicts.

Pushed as commit dfee7b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants