New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)" #2113
Conversation
|
@@ -388,7 +388,7 @@ public static void main(String[] args) throws Exception | |||
MenuBar mb = new MenuBar(); | |||
mb.add(new Menu("Hello")); | |||
frame.setMenuBar(mb); | |||
frame.setBounds(400, 180, 1068, 821); | |||
frame.setBounds(400, 180, 300, 300); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a small resolution(800x600) or similar is used, then the window manager moves this big window to the left/top but the test is expected the specific x/y coordinate.
Webrevs
|
Hi Sergey, I am trying to verify the fix in my mac, if i simply run the test without any change it is throwing error : "Use -nativepath to specify the location of native code". Thanks, |
This test has a native part so you need to specify this option and point it to the built test bundle, or you can run it via make file: |
Thanks for the clarification. |
The problem in the multiscreen environment was caused by using the wrong NScreen to calculate the "y" coordinate. The "NSScreen mainScreen" returns the "Returns the screen object containing the window with the keyboard focus" actually the window where the terminal is located, not the screeen(0,0) expected by the test. |
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@mrserb Since your change was applied there have been 24 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit dfee7b8. |
This test failed on the system where the wrong resolution was used(too small). Looks like that resolution was set by one of the tests and was not reset back because of a misconfigured automatic system reboot. I have checked that the initial version of the test works fine on our "clean" systems. But would like to tweak the test anyway just in case.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2113/head:pull/2113
$ git checkout pull/2113