Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 23, 2024

We still check for PROCESSOR_ARCHITECTURE_IA64 but this is not supported any more for a very long time in OpenJDK.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340623: Remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21130/head:pull/21130
$ git checkout pull/21130

Update a local copy of the PR:
$ git checkout pull/21130
$ git pull https://git.openjdk.org/jdk.git pull/21130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21130

View PR using the GUI difftool:
$ git pr show -t 21130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21130.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340623: Remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding

Reviewed-by: alanb, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 67448b0: 8339852: Fix typos in java.compiler documentation
  • bc7c0dc: 8340084: Open source AWT Frame related tests
  • a07052e: 8340573: Remove unused G1ParScanThreadState::_partial_objarray_chunk_size

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8340623: remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding 8340623: remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding Sep 23, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 23, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2024
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

I thought we had eradicated ia64 from the codebase but it seems we missed a few things in hotspot too. :( I will file an issue to clean that up ...

@MBaesken MBaesken changed the title 8340623: remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding 8340623: Remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding Sep 23, 2024
@MBaesken
Copy link
Member Author

Seems fine.

I thought we had eradicated ia64 from the codebase but it seems we missed a few things in hotspot too. :( I will file an issue to clean that up ...

Thanks for the reviews !

I noticed the HS ia64 references too but was not sure about all of those, maybe some have 'historical' value ;-) !

@dholmes-ora
Copy link
Member

Filed JDK-8340731 for HS cleanup

@MBaesken
Copy link
Member Author

some wget failed in the Windows build, unrelated.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

Going to push as commit 9176f68.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 88801ca: 8340590: RISC-V: C2: Small improvement to vector gather load and scatter store
  • 1dd60b6: 8323688: C2: Fix UB of jlong overflow in PhaseIdealLoop::is_counted_loop()
  • 4098acc: 8340146: ZGC: TestAllocateHeapAt.java should not run with UseLargePages
  • 6c91a16: 8340367: Opensource few AWT image tests
  • 865d99f: 8340596: Remove dead code from RequiresSetenv function in java.base/unix/native/libjli/java_md.c
  • 3411f9d: 8339995: Open source several AWT focus tests - series 6
  • 40cde00: 8340114: Remove outdated SelectVersion() function from the launcher and update the code comments explaining the code flow
  • c8ae848: 8340707: ProblemList applications/ctw/modules/java_base.java due to JDK-8340683
  • cd796e0: 8338918: Remove non translated file name from WinResources resource bundle
  • e97f0fe: 8340365: Position the first window of a window list
  • ... and 12 more: https://git.openjdk.org/jdk/compare/0f253d11033a26d15ea20df19db6765bb274a848...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2024
@openjdk openjdk bot closed this Sep 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@MBaesken Pushed as commit 9176f68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants