Skip to content

8340707: ProblemList applications/ctw/modules/java_base.java due to JDK-8340683 #21146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Sep 24, 2024

Please review

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340707: ProblemList applications/ctw/modules/java_base.java due to JDK-8340683 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21146/head:pull/21146
$ git checkout pull/21146

Update a local copy of the PR:
$ git checkout pull/21146
$ git pull https://git.openjdk.org/jdk.git pull/21146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21146

View PR using the GUI difftool:
$ git pr show -t 21146

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21146.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340707: ProblemList applications/ctw/modules/java_base.java due to JDK-8340683

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cd796e0: 8338918: Remove non translated file name from WinResources resource bundle

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dholmes-ora dholmes-ora changed the title 8340707: ProblemList applications/ctw/modules/java_base.java 8340707: ProblemList applications/ctw/modules/java_base.java due to JDK-8340683 Sep 24, 2024
@dholmes-ora
Copy link
Member Author

/label add hotspot

@openjdk openjdk bot added rfr Pull request is ready for review hotspot hotspot-dev@openjdk.org labels Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@dholmes-ora
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Sep 24, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 24, 2024
@dholmes-ora
Copy link
Member Author

Thanks @jddarcy !

/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

Going to push as commit c8ae848.
Since your change was applied there has been 1 commit pushed to the master branch:

  • cd796e0: 8338918: Remove non translated file name from WinResources resource bundle

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2024
@openjdk openjdk bot closed this Sep 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@dholmes-ora Pushed as commit c8ae848.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants